Fix SQLite defaults for boolean type #922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After cakephp/cakephp#18973 the default values of boolean type for SQLite database are always integers
1or0.It impacts the value of
$defaultattribute passed toSqliteAdapter::parseDefaultValue()that is an integer.As consequence of that a TypeError is thrown calling
preg_match_all($pattern, $default, $matches)because the second attribute must be astring.This PR fixes the error, returning early the
$defaultvalue if isn't a string.In addition tests have been fixed to respect the integer default values.