Skip to content

Fix SQLite defaults for boolean type #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 2 commits into from
Oct 17, 2025
Merged

Fix SQLite defaults for boolean type #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24f766
fix: sqlite defaults for boolean type are always 0 or 1
batopa Oct 17, 2025
64bf546
update cakephp dependencies
batopa Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@
},
"require": {
"php": ">=8.1",
"cakephp/cache": "^5.2",
"cakephp/orm": "^5.2",
"cakephp/cache": "^5.2.9",
"cakephp/database": "^5.2.9",
"cakephp/orm": "^5.2.9",
"robmorgan/phinx": "^0.16.10"
},
"require-dev": {
"cakephp/bake": "^3.3",
"cakephp/cakephp": "^5.2.5",
"cakephp/cakephp": "^5.2.9",
"cakephp/cakephp-codesniffer": "^5.0",
"phpunit/phpunit": "^10.5.5 || ^11.1.3 || ^12.2.4"
},
Expand Down
4 changes: 2 additions & 2 deletions src/Db/Adapter/SqliteAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,8 @@ public function truncateTable(string $tableName): void
*/
protected function parseDefaultValue(mixed $default, string $columnType): mixed
{
if ($default === null) {
return null;
if (!is_string($default)) {
return $default;
}

// split the input into tokens
Expand Down
20 changes: 10 additions & 10 deletions tests/TestCase/Db/Adapter/SqliteAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3147,10 +3147,10 @@ public static function provideDefaultValues()
'Integer 3' => ['create table t(a integer default +1)', 1],
'Integer 4' => ['create table t(a integer default 2112)', 2112],
'Integer 5' => ['create table t(a integer default 002112)', 2112],
'Integer boolean 1' => ['create table t(a boolean default 1)', true],
'Integer boolean 2' => ['create table t(a boolean default 0)', false],
'Integer boolean 3' => ['create table t(a boolean default -1)', -1],
'Integer boolean 4' => ['create table t(a boolean default 2)', 2],
'Integer boolean 1' => ['create table t(a boolean default 1)', 1],
'Integer boolean 2' => ['create table t(a boolean default 0)', 0],
'Integer boolean 3' => ['create table t(a boolean default -1)', 0],
'Integer boolean 4' => ['create table t(a boolean default 2)', 0],
'Float 1' => ['create table t(a float default 1.0)', 1.0],
'Float 2' => ['create table t(a float default +1.0)', 1.0],
'Float 3' => ['create table t(a float default -1.0)', -1.0],
Expand Down Expand Up @@ -3184,12 +3184,12 @@ public function testGetColumnsForBooleanDefaults($tableDef, $exp)
public static function provideBooleanDefaultValues()
{
return [
'True LC' => ['create table t(a boolean default true)', true],
'True UC' => ['create table t(a boolean default TRUE)', true],
'True MC' => ['create table t(a boolean default TRue)', true],
'False LC' => ['create table t(a boolean default false)', false],
'False UC' => ['create table t(a boolean default FALSE)', false],
'False MC' => ['create table t(a boolean default FALse)', false],
'True LC' => ['create table t(a boolean default true)', 1],
'True UC' => ['create table t(a boolean default TRUE)', 1],
'True MC' => ['create table t(a boolean default TRue)', 1],
'False LC' => ['create table t(a boolean default false)', 0],
'False UC' => ['create table t(a boolean default FALSE)', 0],
'False MC' => ['create table t(a boolean default FALse)', 0],
];
}

Expand Down
Loading