Changed migration template to adopt strict types #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think adding the strict types now provides any real measurable effect at this point for the library or the project use of it. More importantly, we probably want to get phpstan to level 6, and make sure we start to add more typehints in general in the next majors probably. |
|
It doesn't hurt to add the strict types requirement for migration files now. |
dereuromark
reviewed
Jun 23, 2020
|
Fair enough. |
|
Can we get a tag for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Phinx targets PHP >= 7.2, it is safe and probably a good idea to include the
strict_typesdeclaration. How good of an idea? Well, not very good, because Phinx's API appears to be entirely devoid of scalar type hints and also missesarraytype hints in places where only arrays are valid. However, once these areas are updated, templates from now on will be configured correctly to take advantage of type hints and the errors generated by mismatching types. Without these type hints, PHP just emits warnings such asInvalid argument supplied for foreach(), but continues regardless until something worse blows up later on.You will also notice I added a few other bonuses which can be reverted if it's too many changes for this PR. First is a
finaltype declaration to signal that migrations are not intended to be inherited (there should be no use case for this). The second is thevoidreturn type hint just to keep static analysers happy. Again, either of these can be reverted but it is not expected to be particularly contentious.