Add declare strict_types to seed template #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
commented
Sep 19, 2023
| @@ -198,7 +198,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
|
|
|||
| $namespace = $config instanceof NamespaceAwareInterface ? $config->getSeedNamespaceByPath($path) : null; | |||
| $classes = [ | |||
| '$namespaceDefinition' => $namespace !== null ? ('namespace ' . $namespace . ';') : '', | |||
| '$namespaceDefinition' => $namespace !== null ? (PHP_EOL . 'namespace ' . $namespace . ';' . PHP_EOL) : '', | |||
There was a problem hiding this comment.
Updating this line so that it looks and works the same as the similar line we have for migrations:
phinx/src/Phinx/Console/Command/Create.php
Line 292 in 09d8f17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a
declare(strict_types=1);to the seed template, which brings it inline with how our migrations template file works, where declare was added in #1819. We should be highly forcing people to have correct types usage when interacting with their database to prevent any sort of unexpected data loss/corruption, such as talked about in the linked PR.