Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar events attached to workflow emails are missing title and meeting link #18194

Open
nikwen opened this issue Dec 15, 2024 · 17 comments
Open
Labels
🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Medium priority Created by Linear-GitHub Sync workflows area: workflows, automations

Comments

@nikwen
Copy link

nikwen commented Dec 15, 2024

Issue Summary

Calendar events attached to workflow emails are missing title and meeting link. Instead, it says "undefined" for the title.

Steps to Reproduce

  1. Create a booking link
  2. Enable workflow emails for that booking link
  3. Select the option "Include calendar event" for those workflow emails
  4. Book a meeting through the link
  5. Wait for the workflow email to come in

Actual Results

The title and meeting link are missing from the calendar event. Instead, it says "undefined" for the title.

CleanShot 2024-12-15 at 13 23 43

Expected Results

The calendar event should have the correct title and meeting link.

Technical details

  • Latest Firefox was used for the booking

Evidence

Screenshot: see above

@nikwen nikwen added the 🐛 bug Something isn't working label Dec 15, 2024
@dosubot dosubot bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email workflows area: workflows, automations labels Dec 15, 2024
@GARY121github
Copy link

Hello @nikwen can I work on this issue?

@nikwen
Copy link
Author

nikwen commented Dec 15, 2024

@GARY121github As far as I know, everyone is free to submit pull requests.

@VK-RED
Copy link
Contributor

VK-RED commented Dec 16, 2024

image
@nikwen I Tried replicating the issue , I can see the meeting url is broken for sure , but the title appears to be fine ..

@GARY121github
Copy link

@nikwen Yes I have also replicated that and it is working fine

@nikwen
Copy link
Author

nikwen commented Dec 16, 2024

Thanks for checking! When I open the CSV ICS file in a text editor, I see the following lines:

SUMMARY:undefined
DESCRIPTION:What:\nundefined\n  \n\nInvitee Time Zone:\nEurope/Berlin\n...
LOCATION:integrations:zoom

@VK-RED Could you please check the attached CSV ICS file in a text editor? It could be that Gmail is fixing the title somehow by having additional logic that pulls it from the email body.

@VK-RED
Copy link
Contributor

VK-RED commented Dec 17, 2024

image
image

@nikwen I can see only the .ics file and it seems to be working , how are u getting a .csv ?

@VK-RED
Copy link
Contributor

VK-RED commented Dec 17, 2024

image
I though I had setup meet integration, but I wasn't so make sure to check that or if you want to use cal video make sure to get the daily.co API key !!

@nikwen
Copy link
Author

nikwen commented Dec 17, 2024

Sorry, I meant ICS instead of CSV, of course. :)

I received multiple emails where title and meeting URL were missing from the ICS files attached to workflow emails (but were present in the original booking confirmation email).

The video call integration is set up properly.

@VK-RED
Copy link
Contributor

VK-RED commented Dec 19, 2024

image

Tried multiple times, Can't able to reproduce the title: undefined & description:undefined

I can only see Location being integrations:google:meet , so do you need the actual meeting link inplace of integrations:google:meet ?

@nikwen
Copy link
Author

nikwen commented Dec 19, 2024

Thanks for testing, @VK-RED! I've started another test to see if I can still reproduce the title and description being undefined. I'll let you know.

For the location, yes, that should be the meeting link (just like in the booking confirmation email).

@nikwen
Copy link
Author

nikwen commented Dec 20, 2024

I'm still seeing this on Cal.com. Below you can see a screenshot of an event I received today:

Screenshot

@VK-RED
Copy link
Contributor

VK-RED commented Dec 20, 2024

Hmmm, Tried with Multiple Integrations I cant replicate the broken titles, but was able to replicate the meeting url though and raisd a PR for it !!

image
image

@nikwen
Copy link
Author

nikwen commented Dec 20, 2024

Thank you so much for the PR, @VK-RED! Fixing the meeting URL is a great step already.

Any chance we can update the PR so that it won't automatically close this issue when it's merged?
The meeting title will need to be fixed, too, before the issue can be closed. Thanks!

@VK-RED
Copy link
Contributor

VK-RED commented Dec 20, 2024

Sure, I would love to fix the title as well , but I couldn't able to see the title as undefined

@nikwen
Copy link
Author

nikwen commented Dec 20, 2024

Oh, I meant: Can we update the PR to not say "Fixes #18194"? Because otherwise this issue will be closed (even though it isn't fully fixed) when the PR gets merged. Sorry if that wasn't clear!

@nikwen
Copy link
Author

nikwen commented Dec 20, 2024

In other projects I've worked on, people would use "Refs #18194" to indicate that.

@VK-RED
Copy link
Contributor

VK-RED commented Dec 20, 2024

Yeah would do that!!

@Praashh Praashh added the Medium priority Created by Linear-GitHub Sync label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Medium priority Created by Linear-GitHub Sync workflows area: workflows, automations
Projects
None yet
Development

No branches or pull requests

4 participants