-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar events attached to workflow emails are missing title and meeting link #18194
Comments
Hello @nikwen can I work on this issue? |
@GARY121github As far as I know, everyone is free to submit pull requests. |
|
@nikwen Yes I have also replicated that and it is working fine |
Thanks for checking! When I open the
@VK-RED Could you please check the attached |
@nikwen I can see only the .ics file and it seems to be working , how are u getting a .csv ? |
Sorry, I meant ICS instead of CSV, of course. :) I received multiple emails where title and meeting URL were missing from the ICS files attached to workflow emails (but were present in the original booking confirmation email). The video call integration is set up properly. |
Thanks for testing, @VK-RED! I've started another test to see if I can still reproduce the title and description being undefined. I'll let you know. For the location, yes, that should be the meeting link (just like in the booking confirmation email). |
Thank you so much for the PR, @VK-RED! Fixing the meeting URL is a great step already. Any chance we can update the PR so that it won't automatically close this issue when it's merged? |
Sure, I would love to fix the title as well , but I couldn't able to see the title as undefined |
Oh, I meant: Can we update the PR to not say "Fixes #18194"? Because otherwise this issue will be closed (even though it isn't fully fixed) when the PR gets merged. Sorry if that wasn't clear! |
In other projects I've worked on, people would use "Refs #18194" to indicate that. |
Yeah would do that!! |
Issue Summary
Calendar events attached to workflow emails are missing title and meeting link. Instead, it says "undefined" for the title.
Steps to Reproduce
Actual Results
The title and meeting link are missing from the calendar event. Instead, it says "undefined" for the title.
Expected Results
The calendar event should have the correct title and meeting link.
Technical details
Evidence
Screenshot: see above
The text was updated successfully, but these errors were encountered: