chore: sort calendar crendentials in event manager #15448
Conversation
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
calendar-apps
Graphite Automations"Add community label" took an action on this PR • (06/16/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
@hariombalhara I am confused - in the linked issue #11671 you wrote:
we erroneously consider that credential as the first one, instead of the first added one actually.
but by sorting it by DESC using:
.sort((a, b) => {
return b.id - a.id;
});
we have last added calendar as the default fallback one, but the function for falling back is called fallbackToFirstConnectedCalendar.
So - do we want by default to fallback to the first connected calendar, or to the latest one?
If first connected, we need to sort in ASCENDING order by id. I think this makes most sense - fallback to first connected.
If by latest one, we need to rename fallbackToFirstConnectedCalendar to fallbackToLastConnectedCalendar.
|
@supalarry Yeah the statement isn't correct. I meant we need to have the latest added one consistently which would be the first one if we do sort in descending. The same way we do for Also, |
packages/core/EventManager.ts
Outdated
| .sort((a, b) => { | ||
| return b.id - a.id; | ||
| }); |
There was a problem hiding this comment.
how about we name this arrow function, latestFirst and reuse it below as well.
Makes the code more readable
There was a problem hiding this comment.
Do you mean oldestFirst as we are sorting in ascending order
There was a problem hiding this comment.
I think we are sorting in descending order only, unless I am misunderstanding
There was a problem hiding this comment.
Thanks @Shaik-Sirajuddin !!
I left a quick to implement suggestion otherwise it's good.
Updated function names as suggested |
Variable name change
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits) chore: v4.2.5 (calcom#15735) fix: api v2 unit tests (calcom#15733) fix: event type back button (calcom#15722) fix: remove console.log and tsignore apiv2 (calcom#15732) fix: api-v2 controllers e2e tests (calcom#15724) fix: Text in Embed Code Visibility Fixed (calcom#15711) chore: sort calendar crendentials in event manager (calcom#15448) chore: cache org guard and fix roles guard apiv2 (calcom#15719) Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720) feat: add POST end point to mark calls as no-shows (calcom#15690) chore: add i18n to atoms (calcom#15698) fix: set conferencing apps as default (calcom#15376) fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702) fix: Rescheduling email when there is broken calendar integration (calcom#15669) chore: v4.2.4 (calcom#15703) fix: 404s becoming 500s (calcom#15696) fix: delete reserved slot on booker unmount (calcom#15700) chore: add caching apiv2 roles guard (calcom#15694) refactor: handleNewBooking calcom#3 (calcom#15612) fix: incorrect booking seats full error on collective seated event (calcom#15602) ... # Conflicts: # packages/emails/templates/attendee-request-email.ts # packages/emails/templates/attendee-was-requested-to-reschedule-email.ts # packages/emails/templates/organizer-cancelled-email.ts # packages/emails/templates/organizer-location-change-email.ts # packages/emails/templates/organizer-payment-refund-failed-email.ts # packages/emails/templates/organizer-request-email.ts # packages/emails/templates/organizer-request-reminder-email.ts # packages/emails/templates/organizer-requested-to-reschedule-email.ts # packages/emails/templates/organizer-rescheduled-email.ts # packages/emails/templates/organizer-scheduled-email.ts
* chore_sort_calendar_credentials_in_desc_for_reliability * chore: create reusable function * refactor: rename functions * Update EventManager.ts Variable name change --------- Co-authored-by: Shaik-Sirajuddin <sirajudddinshaik30@gmail.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Udit Takkar <udit222001@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)