refactor: handleNewBooking #3 #15612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/28/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
commented
Jun 28, 2024
| @@ -0,0 +1,81 @@ | |||
| import type { App } from "@prisma/client"; | |||
There was a problem hiding this comment.
moved all the types here
Udit-takkar
commented
Jun 28, 2024
Comment on lines
+80
to
+99
| const newBookingData = buildNewBookingData({ | ||
| uid, | ||
| evt, | ||
| responses, | ||
| isConfirmedByDefault, | ||
| reqBodyMetadata, | ||
| smsReminderNumber, | ||
| eventTypeSlug, | ||
| organizerUser, | ||
| reqBodyRecurringEventId, | ||
| originalRescheduledBooking, | ||
| bookerEmail, | ||
| rescheduleReason, | ||
| eventType, | ||
| eventTypeId, | ||
| reqBodyUser, | ||
| }); | ||
|
|
||
| return await saveBooking(newBookingData, originalRescheduledBooking, paymentAppData, organizerUser); | ||
| } |
There was a problem hiding this comment.
Refactored to smaller functions
Udit-takkar
commented
Jun 28, 2024
| return dateRangeForBooking; | ||
| }; | ||
|
|
||
| export async function ensureAvailableUsers( |
There was a problem hiding this comment.
some refactoring and cleaning up
Udit-takkar
commented
Jul 2, 2024
| @@ -0,0 +1,48 @@ | |||
| import prisma from "@calcom/prisma"; | |||
|
|
|||
| export const findBookingQuery = async (bookingId: number) => { | |||
There was a problem hiding this comment.
TODO: move these queries to repository in this PR #15447
packages/features/bookings/lib/handleNewBooking/getRequiresConfirmationFlags.ts
Show resolved
Hide resolved
hariombalhara
approved these changes
Jul 8, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
3 tasks
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
False alarm by sentry. /v1/booking endpoint is working fine. Few bad requests were made to create booking |
verstratenbram
added a commit
to verstratenbram/cal.com
that referenced
this pull request
Jul 16, 2024
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits) chore: v4.2.5 (calcom#15735) fix: api v2 unit tests (calcom#15733) fix: event type back button (calcom#15722) fix: remove console.log and tsignore apiv2 (calcom#15732) fix: api-v2 controllers e2e tests (calcom#15724) fix: Text in Embed Code Visibility Fixed (calcom#15711) chore: sort calendar crendentials in event manager (calcom#15448) chore: cache org guard and fix roles guard apiv2 (calcom#15719) Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720) feat: add POST end point to mark calls as no-shows (calcom#15690) chore: add i18n to atoms (calcom#15698) fix: set conferencing apps as default (calcom#15376) fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702) fix: Rescheduling email when there is broken calendar integration (calcom#15669) chore: v4.2.4 (calcom#15703) fix: 404s becoming 500s (calcom#15696) fix: delete reserved slot on booker unmount (calcom#15700) chore: add caching apiv2 roles guard (calcom#15694) refactor: handleNewBooking calcom#3 (calcom#15612) fix: incorrect booking seats full error on collective seated event (calcom#15602) ... # Conflicts: # packages/emails/templates/attendee-request-email.ts # packages/emails/templates/attendee-was-requested-to-reschedule-email.ts # packages/emails/templates/organizer-cancelled-email.ts # packages/emails/templates/organizer-location-change-email.ts # packages/emails/templates/organizer-payment-refund-failed-email.ts # packages/emails/templates/organizer-request-email.ts # packages/emails/templates/organizer-request-reminder-email.ts # packages/emails/templates/organizer-requested-to-reschedule-email.ts # packages/emails/templates/organizer-rescheduled-email.ts # packages/emails/templates/organizer-scheduled-email.ts
p6l-richard
pushed a commit
to p6l-richard/cal.com-fork
that referenced
this pull request
Jul 22, 2024
* refactor: handleNewBooking calcom#3 * fix: type error * fix: type err * fix: type err * refactor: create booking factor * chore: refactor availusers * chore: type err --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuing refactor of handleNewBooking
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?