fix: more general translation for 'seats 'in NL #16722
Conversation
|
|
|
@SDeVuyst is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/19/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (09/19/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (09/20/24)1 label was added to this PR based on Keith Williams's automation. |
| "multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen zitplaatsenoptie", | ||
| "no_show_fee_doesnt_support_seats": "No-show vergoeding ondersteunt geen zitplaatsenoptie", | ||
| "seats_option_doesnt_support_multi_location": "Zitplaatsenoptie ondersteunt geen Meerdere Locaties", | ||
| "multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen plaatsenoptie", |
There was a problem hiding this comment.
But isn't 'plaatsen' define a physical place or location, and everywhere I've seen, 'zitplaatsen' specifically defines seats?
There was a problem hiding this comment.
not really. Plaatsen can refer to a physical location as well, but also a spot in a queue for example. zitplaatsen refers specifically to seated spots, so for example if you want to reserve a spot at your local sportsclub, then 'plaats' would be a better translation. Unless the purpose of the seats is only for physical seats but I don't see why you would limit yourself to just that.
There was a problem hiding this comment.
@SDeVuyst is correct - zitplaats has a specific meaning such as a "physical seat" at a concert, or at a table, it may have "12 zitplaatsen" - strictly speaking it's not wrong - however, "plaatsen" should still be correctly interpreted by the reader as how many places are still available within the context of the event (you're meant to "place yourself" for an event, not to be seated for an event). Long story short, it's correct.
| "multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen zitplaatsenoptie", | ||
| "no_show_fee_doesnt_support_seats": "No-show vergoeding ondersteunt geen zitplaatsenoptie", | ||
| "seats_option_doesnt_support_multi_location": "Zitplaatsenoptie ondersteunt geen Meerdere Locaties", | ||
| "multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen plaatsenoptie", |
There was a problem hiding this comment.
@SDeVuyst is correct - zitplaats has a specific meaning such as a "physical seat" at a concert, or at a table, it may have "12 zitplaatsen" - strictly speaking it's not wrong - however, "plaatsen" should still be correctly interpreted by the reader as how many places are still available within the context of the event (you're meant to "place yourself" for an event, not to be seated for an event). Long story short, it's correct.
E2E results are ready! |
What does this PR do?
This provides a more general translation for 'seats' in dutch. It changes 'zitplaatsen' to 'plaatsen'. This is a better translation since it is more universal.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Since this is just an i18n PR, i don't think many tests are in order.