Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more general translation for 'seats 'in NL #16722

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/web/public/static/locales/nl/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@
"link_expires": "p.s. De uitnodiging verloopt over {{expiresIn}} uur.",
"upgrade_to_per_seat": "Upgraden naar per plaats",
"seat_options_doesnt_support_confirmation": "De optie plaatsen optie ondersteunt geen bevestigingseis",
"multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen zitplaatsenoptie",
"no_show_fee_doesnt_support_seats": "No-show vergoeding ondersteunt geen zitplaatsenoptie",
"seats_option_doesnt_support_multi_location": "Zitplaatsenoptie ondersteunt geen Meerdere Locaties",
"multilocation_doesnt_support_seats": "Meerdere Locaties ondersteunt geen plaatsenoptie",
Copy link
Contributor

@anikdhabal anikdhabal Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't 'plaatsen' define a physical place or location, and everywhere I've seen, 'zitplaatsen' specifically defines seats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really. Plaatsen can refer to a physical location as well, but also a spot in a queue for example. zitplaatsen refers specifically to seated spots, so for example if you want to reserve a spot at your local sportsclub, then 'plaats' would be a better translation. Unless the purpose of the seats is only for physical seats but I don't see why you would limit yourself to just that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDeVuyst is correct - zitplaats has a specific meaning such as a "physical seat" at a concert, or at a table, it may have "12 zitplaatsen" - strictly speaking it's not wrong - however, "plaatsen" should still be correctly interpreted by the reader as how many places are still available within the context of the event (you're meant to "place yourself" for an event, not to be seated for an event). Long story short, it's correct.

"no_show_fee_doesnt_support_seats": "No-show vergoeding ondersteunt geen plaatsenoptie",
"seats_option_doesnt_support_multi_location": "Plaatsenoptie ondersteunt geen Meerdere Locaties",
"team_upgrade_seats_details": "Van de {{memberCount}} leden in uw team zijn {{unpaidCount}} plaats(en) onbetaald. Voor $ {{seatPrice}}/maand per plaats bedragen de geschatte totale kosten van uw abonnement $ {{totalCost}}/maand.",
"team_upgrade_banner_description": "Bedankt voor het testen van ons nieuwe teamabonnement. We hebben geconstateerd dat uw team \"{{teamName}}\" moet worden geüpgraded.",
"upgrade_banner_action": "Hier upgraden",
Expand Down Expand Up @@ -1064,17 +1064,17 @@
"external_redirect_url": "https://voorbeeld.com/omleiding-naar-mijn-succespagina",
"redirect_url_description": "Leid door naar een aangepaste URL na een geslaagde boeking",
"duplicate": "Dupliceren",
"offer_seats": "Zitplaatsen aanbieden",
"offer_seats": "Plaatsen aanbieden",
"offer_seats_description": "Bied beschikbare plaatsen aan voor boekingen. Hiermee worden gastboekingen en aanmeldingsboekingen automatisch uitgeschakeld.",
"seats_available_one": "Plaats beschikbaar",
"seats_available_other": "Beschikbare zitplaatsen",
"seats_available_other": "Beschikbare plaatsen",
"seats_nearly_full": "Plaatsen bijna vol",
"seats_half_full": "Plaatsen raken snel vol",
"number_of_seats": "Aantal zitplaatsen per boeking",
"number_of_seats": "Aantal plaatsen per boeking",
"set_instant_meeting_expiry_time_offset_description": "Stel vergaderingsvenster in (seconden): De tijdsperiode in seconden waarin de host de vergadering kan joinen en starten. Na deze periode verloopt de join-URL van de vergadering.",
"enter_number_of_seats": "Voer het aantal zitplaatsen in",
"enter_number_of_seats": "Voer het aantal plaatsen in",
"you_can_manage_your_schedules": "U kunt uw schema's beheren op de beschikbaarheidspagina.",
"booking_full": "Geen zitplaatsen meer beschikbaar",
"booking_full": "Geen plaatsen meer beschikbaar",
"api_keys": "API-sleutels",
"api_key": "API-sleutel",
"test_api_key": "API-sleutel testen",
Expand Down
Loading