Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: powered by rendering above select/multi select #16857

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: powered by rendering above select/multi select #16857

wants to merge 7 commits into from
+2 −0

Conversation

sean-brydon
Copy link
Member

What does this PR do?

This issue was introduced when removing the Z index for the powered by logo to make it clickable:
#16842

Before:
image

After:
image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Add select/multi select to booking form
Open it and ensure that it renders above the POWERED BY logo

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team September 27, 2024 10:48
@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix powered by  rendering above select/multi select". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 27, 2024
@dosubot dosubot bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Sep 27, 2024
sean-brydon
sean-brydon commented Sep 27, 2024
View reviewed changes
packages/app-store/routing-forms/components/react-awesome-query-builder/widgets.tsx
@@ -181,6 +181,7 @@ const MultiSelectWidget = ({
isMulti={true}
isDisabled={remainingProps.readOnly}
options={selectItems}
menuPortalTarget={document.body}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier portaling this to the body instead of dealing with the isolation of stackable content when inside this weird grid/subgrid

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 27, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/27/24)

1 label was added to this PR based on Keith Williams's automation.

CarinaWolli
CarinaWolli approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CarinaWolli CarinaWolli enabled auto-merge (squash) September 27, 2024 13:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

E2E results are ready!

@anikdhabal anikdhabal changed the title fix powered by rendering above select/multi select fix: powered by rendering above select/multi select Sep 27, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 0:06am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 0:06am

@CarinaWolli
Copy link
Member

@sean-brydon e2e tests continue to fail

@sean-brydon
Copy link
Member Author

@sean-brydon e2e tests continue to fail

Hmmmm - will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sean-brydon @CarinaWolli @PeerRich @keithwillcode @joeauyeung