Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: powered by rendering above select/multi select #16857

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+2 −0
Open

fix: powered by rendering above select/multi select #16857

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad5262b
fix POWEREDBY rendering above menu
sean-brydon Sep 27, 2024
b7f081f
Merge branch 'main' into fix/cal.com-logo-clickable
CarinaWolli Sep 27, 2024
b396f6e
Merge branch 'main' into fix/cal.com-logo-clickable
sean-brydon Sep 29, 2024
39c9e3f
Merge branch 'main' into fix/cal.com-logo-clickable
CarinaWolli Sep 30, 2024
cf62f56
Merge branch 'main' into fix/cal.com-logo-clickable
joeauyeung Oct 3, 2024
ae2481e
Merge branch 'main' into fix/cal.com-logo-clickable
PeerRich Oct 7, 2024
57e4737
Merge branch 'main' into fix/cal.com-logo-clickable
PeerRich Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/app-store/routing-forms/components/react-awesome-query-builder/widgets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ const MultiSelectWidget = ({
isMulti={true}
isDisabled={remainingProps.readOnly}
options={selectItems}
menuPortalTarget={document.body}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier portaling this to the body instead of dealing with the isolation of stackable content when inside this weird grid/subgrid

{...remainingProps}
/>
);
Expand Down Expand Up @@ -218,6 +219,7 @@ function SelectWidget({ listValues, setValue, value, ...remainingProps }: Select
isDisabled={remainingProps.readOnly}
value={optionFromList}
options={selectItems}
menuPortalTarget={document.body}
{...remainingProps}
/>
);
Expand Down
Loading