Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove 2 steps from the onboarding flow for google signups #17787

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: remove 2 steps from the onboarding flow for google signups #17787

wants to merge 9 commits into from
+176 −132

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Nov 21, 2024 •
edited
Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go through a sign up process using (1) Google sign-in and (2) Normal email sign-in. DM me if you need help with this.

@graphite-app graphite-app bot requested a review from a team November 21, 2024 17:31
@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 4:27am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 4:27am

@dosubot dosubot bot added the ✨ feature New feature or request label Nov 21, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Nov 21, 2024
@hbjORbj hbjORbj marked this pull request as draft November 21, 2024 17:33
@hbjORbj hbjORbj changed the title feat: make the onboarding flow 3-step for google signups feat: remove 2 steps from the onboarding flow for google signups Nov 21, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as ready for review November 22, 2024 03:30
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Nov 22, 2024
@hbjORbj hbjORbj enabled auto-merge (squash) November 22, 2024 03:46
hbjORbj
hbjORbj commented Nov 22, 2024
View reviewed changes
packages/ui/components/form/step/steps.test.tsx
stepLabel: (currentStep: number, totalSteps: number) => `Test Step ${currentStep} of ${totalSteps}`,
disableNavigation: undefined,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes type error that existed in this test file

@hbjORbj hbjORbj mentioned this pull request Nov 22, 2024
Draft
3 tasks
@hbjORbj hbjORbj marked this pull request as draft November 24, 2024 05:46
auto-merge was automatically disabled November 24, 2024 05:46

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only ✨ feature New feature or request ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode