feat: add drop off funnel chart for /insights/routing#22106
Merged
eunjae-lee merged 42 commits intomainfrom Jul 16, 2025
Merged
feat: add drop off funnel chart for /insights/routing#22106eunjae-lee merged 42 commits intomainfrom
eunjae-lee merged 42 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
0ab4320 to
4ab828b
Compare
|
✅ No security or compliance issues detected. Reviewed everything up to 9df6903. Security Overview
Detected Code Changes
Reply to this PR with |
5 tasks
e36c5d1 to
69c1330
Compare
1d7a251 to
a377281
Compare
This was referenced Jul 25, 2025
Closed
This was referenced Aug 22, 2025
This was referenced Sep 6, 2025
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add drop off funnel chart for /insights/routing
Summary
This PR adds a drop-off funnel chart visualization to the
/insights/routingpage that shows user progression through routing form steps. The chart displays three key metrics:Key Implementation Details:
getDropOffDataendpoint that uses the InsightsRoutingServiceReview & Testing Checklist for Human
ctx.user.organizationIdis null orinput.selectedTeamIdis undefinedRecommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD subgraph "Frontend" A["DropOffFunnel.tsx"]:::major-edit B["dropoff/page.tsx"]:::major-edit end subgraph "tRPC Layer" C["trpc-router.ts"]:::major-edit end subgraph "Services (PR #22166)" D["insightsRouting.ts"]:::minor-edit E["insightsBooking.ts"]:::context end subgraph "Database" F["RoutingFormResponseDenormalized"]:::context end A --> C B --> D C --> D D --> F subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
maintodevin/insights-services-kysely-1735668293to properly reflect the stacking relationshipctx.user.organizationId(nullable) andinput.selectedTeamId(optional) were being passed to service constructor expecting non-null numbersDemo
Playground
/settings/admin/playground/routing-funnelRouting Funnel
/insights/routing