Skip to content

Comments

fix: changesets atoms release env variables#22773

Merged
supalarry merged 2 commits intomainfrom
fix-changesets-env-variables
Jul 28, 2025
Merged

fix: changesets atoms release env variables#22773
supalarry merged 2 commits intomainfrom
fix-changesets-env-variables

Conversation

@supalarry
Copy link
Contributor

Morgan told me that when releasing atoms atoms/.env should have following env variables set

VITE_BOOKER_EMBED_OAUTH_CLIENT_ID
VITE_BOOKER_EMBED_API_URL
NEXT_PUBLIC_WEBAPP_URL

This PR extracts them from environment so that they are available during the atoms build.

@graphite-app graphite-app bot requested a review from a team July 28, 2025 11:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 28, 2025

Walkthrough

The GitHub Actions workflow file .github/workflows/changesets.yml was updated to include three additional environment variables—VITE_BOOKER_EMBED_OAUTH_CLIENT_ID, VITE_BOOKER_EMBED_API_URL, and NEXT_PUBLIC_WEBAPP_URL—in the "Create Release Pull Request or Publish to npm" step. These variables are sourced from repository secrets. No other modifications were made to the workflow's logic, permissions, or structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee073cd and 2103cb3.

📒 Files selected for processing (1)
  • .github/workflows/changesets.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/changesets.yml (2)

35-37: NODE_AUTH_TOKEN and NPM_TOKEN both reference the same secret – intentional?

NODE_AUTH_TOKEN and NPM_TOKEN are set to identical values (${{ secrets.NPM_TOKEN }}).
If the registry you publish to treats them interchangeably, this is fine. Otherwise, confirm whether:

  1. A distinct secret for NODE_AUTH_TOKEN is required.
  2. One of the two variables can be removed to avoid confusion.

38-40: New atoms release env vars correctly wired in.

The three additional environment variables are passed through as secrets with the expected names — this unblocks the atoms build without exposing values in logs. Looks good.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-changesets-env-variables

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jul 28, 2025
@graphite-app graphite-app bot requested a review from a team July 28, 2025 11:00
@dosubot dosubot bot added the ❗️ .env changes contains changes to env variables label Jul 28, 2025
@graphite-app
Copy link

graphite-app bot commented Jul 28, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (07/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 28, 2025 0:01am
cal-eu ⬜️ Ignored (Inspect) Jul 28, 2025 0:01am

@supalarry supalarry merged commit 6b10127 into main Jul 28, 2025
39 of 40 checks passed
@supalarry supalarry deleted the fix-changesets-env-variables branch July 28, 2025 13:52
@coderabbitai coderabbitai bot mentioned this pull request Aug 21, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ❗️ .env changes contains changes to env variables platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants