chore: update env variables for atoms e2e yml#23883
Conversation
WalkthroughThe PR modifies .github/workflows/e2e-atoms.yml by adding two environment variables in the workflow’s env block: ATOMS_E2E_APPLE_ID and ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE. Each variable references a corresponding GitHub Actions secret with the same name (secrets.ATOMS_E2E_APPLE_ID and secrets.ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE). No other workflow steps, jobs, or configurations are changed. Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
keithwillcode
added
core
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/e2e-atoms.yml (2)
16-17: Scope secrets to only the step that needs them to reduce exposure.Top-level
envexposes these secrets to every step, including third‑party actions. Prefer step‑levelenvfor “Run E2E Atoms Tests”.env: NODE_OPTIONS: --max-old-space-size=8096 ATOMS_E2E_OAUTH_CLIENT_ID: ${{ secrets.ATOMS_E2E_OAUTH_CLIENT_ID }} ATOMS_E2E_OAUTH_CLIENT_SECRET: ${{ secrets.ATOMS_E2E_OAUTH_CLIENT_SECRET }} ATOMS_E2E_API_URL: ${{ secrets.ATOMS_E2E_API_URL }} ATOMS_E2E_ORG_ID: ${{ secrets.ATOMS_E2E_ORG_ID }} ATOMS_E2E_OAUTH_CLIENT_ID_BOOKER_EMBED: ${{ secrets.ATOMS_E2E_OAUTH_CLIENT_ID_BOOKER_EMBED }} - ATOMS_E2E_APPLE_ID: ${{ secrets.ATOMS_E2E_APPLE_ID }} - ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE: ${{ secrets.ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE }} DATABASE_DIRECT_URL: ${{ secrets.CI_DATABASE_URL }} DATABASE_URL: ${{ secrets.CI_DATABASE_URL }} @@ - name: Run E2E Atoms Tests working-directory: packages/platform/examples/base + env: + ATOMS_E2E_APPLE_ID: ${{ secrets.ATOMS_E2E_APPLE_ID }} + ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE: ${{ secrets.ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE }} run: yarn test:e2e
16-17: Terminology nit: considerAPP_STORE_CONNECTin the name.Apple’s product is “App Store Connect”;
APPLE_CONNECTmay confuse future readers.If renaming is feasible without breaking callers/secrets, prefer:
ATOMS_E2E_APP_STORE_CONNECT_APP_SPECIFIC_PASSWORD- Keep current as an alias during migration if needed.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/e2e-atoms.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (1)
.github/workflows/e2e-atoms.yml (1)
16-17: Make secrets available to this reusable workflow (declare or ensure callers pass them).Because this workflow is invoked via
workflow_call,${{ secrets.* }}will be empty unless the reusable workflow declares the secrets underworkflow_call: secrets:or every caller passes them (or usessecrets: inherit). If not wired, jobs will run with empty env vars and tests may fail.Two options:
- Declare required secrets here (preferred) — add:
on: - workflow_call: + workflow_call: + secrets: + ATOMS_E2E_APPLE_ID: + required: true + ATOMS_E2E_APPLE_CONNECT_APP_SPECIFIC_PASSCODE: + required: true
- Or confirm each caller uses
secrets: inheritor maps these secrets when calling.To locate callers, run:
grep -RIn --include="*.yml" --include="*.yaml" "e2e-atoms.yml" .github/workflows || echo "No callers found"
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
E2E results are ready! |
4 participants
No description provided.