Skip to content

Comments

feat: [Booking Flow Refactor - 4] Add BookingValidationService#23797

Closed
hariombalhara wants to merge 1 commit intographite-base/23797from
hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation
Closed

feat: [Booking Flow Refactor - 4] Add BookingValidationService#23797
hariombalhara wants to merge 1 commit intographite-base/23797from
hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation

Conversation

@hariombalhara
Copy link
Member

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@linear
Copy link

linear bot commented Sep 12, 2025

PRI-305

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add BookingValidationService". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Sep 12, 2025
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from d8adfd5 to ee014a0 Compare September 12, 2025 14:46
@vercel
Copy link

vercel bot commented Sep 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Sep 23, 2025 9:20am
cal-eu Ignored Ignored Sep 23, 2025 9:20am

@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from ee014a0 to 03f567e Compare September 13, 2025 08:02
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 03f567e to 8d06735 Compare September 14, 2025 06:24
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 8d06735 to 61355c1 Compare September 14, 2025 07:01
@hariombalhara hariombalhara changed the title Add quickEnrichment and quickValidation phases Add BookingValidationService Sep 15, 2025
@hariombalhara hariombalhara changed the title Add BookingValidationService feat: Add BookingValidationService Sep 15, 2025
@hariombalhara hariombalhara changed the title feat: Add BookingValidationService feat: [Booking Flow Refactor] Add BookingValidationService Sep 15, 2025
@hariombalhara hariombalhara changed the title feat: [Booking Flow Refactor] Add BookingValidationService feat: [Booking Flow Refactor - 4] Add BookingValidationService Sep 15, 2025
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from 334634b to 106ab66 Compare September 15, 2025 11:14
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 61355c1 to 3c78374 Compare September 15, 2025 11:14
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 3c78374 to 82d6e28 Compare September 16, 2025 10:38
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch 2 times, most recently from bd6c31c to fefc3ba Compare September 16, 2025 11:11
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 82d6e28 to 033ea95 Compare September 16, 2025 11:11
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from fefc3ba to c77cffc Compare September 17, 2025 09:55
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 033ea95 to 90e3547 Compare September 17, 2025 09:55
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from c77cffc to c58663f Compare September 22, 2025 09:50
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 90e3547 to dee6f2d Compare September 22, 2025 09:50
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from dee6f2d to 155ad02 Compare September 22, 2025 13:09
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from c58663f to 14d02b7 Compare September 22, 2025 13:09
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from 14d02b7 to 9ae5c60 Compare September 22, 2025 14:04
@hariombalhara hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-phases-1-quick-enrichment-and-validation branch from 155ad02 to e0ce121 Compare September 22, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants