chore: [Booking Flow Refactor - 5] Move post booking things to separate service `BookingEventHandlerService` starting with HashedLink usage handling by hariombalhara · Pull Request #24025 · calcom/cal.com

hariombalhara · 2025-09-24T07:41:58Z

What does this PR do?

This PR refactors post-booking logic by extracting it from the main booking flow into a dedicated BookingEventHandler service. This is the first step in improving the post booking architecture by separating concerns and making the codebase more maintainable.

Key Changes:

Extracts hashed link usage tracking from inline code into a new BookingEventHandler service
Introduces type-safe event payloads for booking creation and rescheduling events
Uses dependency injection everywhere
Adds comprehensive test coverage for post-booking event handling to ensure no regression

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Environment Setup

Standard Cal.com development environment
PostgreSQL database for hashed link functionality

Test Scenarios

Hashed Link Creation: Create a booking with a hashed link and verify usage count increments
Hashed Link Rescheduling: Reschedule a booking with a hashed link and verify usage tracking
Dry Run Handling: Ensure dry runs don't increment usage counts
Error Handling: Verify that hashed link service errors don't break booking creation

Expected Behavior

All existing booking functionality should work unchanged
Hashed link usage tracking should continue to work exactly as before
Post-booking errors should be logged but not break the booking flow
Tests in packages/features/bookings/lib/handleNewBooking/test/post-booking-handling.test.ts should pass

Checklist

⚠️ Critical Review Areas:

Verify BookingEventHandler Integration: Ensure the BookingEventHandler is properly instantiated and called in the booking flow (around line 2063 in RegularBookingService.ts)
Error Handling Strategy: Confirm that changing from throwing HttpError to logging errors is the intended behavior for post-booking failures
Dependency Injection Configuration: Validate that all DI modules are properly configured and dependencies are correctly wired
Service Location Changes: Check that moving HashedLinkService doesn't break any existing imports or functionality
Test Coverage vs Implementation: The tests simulate hashed link increments rather than fully mocking the service - verify this doesn't hide integration issues

Architectural Changes:

New BookingEventHandler class properly handles both creation and rescheduling events
Type definitions in onBookingEvents/types.d.ts are comprehensive and accurate
Dependency injection setup follows Cal.com patterns and conventions
Error boundaries prevent post-booking failures from affecting booking creation

Backward Compatibility:

All existing booking flows continue to work unchanged
Hashed link functionality maintains exact same behavior
No breaking changes to public APIs or interfaces

Link to Devin run: https://app.devin.ai/sessions/4465fc388ef1433d80ca534e6c4ec2dd
PR Description Requested by: @hariombalhara

Note: This refactoring provides a foundation for incrementally moving additional post-booking functionality (webhooks, notifications, analytics) into the event handler pattern in future PRs.

linear · 2025-09-24T07:42:02Z

PRI-305

vercel · 2025-09-24T07:42:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
cal	Ignored			Oct 23, 2025 10:37am
cal-eu	Ignored			Oct 23, 2025 10:37am

coderabbitai · 2025-09-24T07:42:05Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch hariom-pri-305-post-booking-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

hariombalhara · 2025-09-24T07:42:29Z

chore: [Booking Flow Refactor - 5] Move post booking things to separate service BookingEventHandlerService starting with HashedLink usage handling #24025 👈 (View in Graphite)
feat: [Booking flow refactor - 3] Rename booking handlers to service names and remove Prisma import from InstantBookingCreateService #23682 : 3 other dependent PRs (#23797 , #23839 , #24022 )
chore: [Booking flow refactor - 2] Integrate Booking services #23156 : 2 other dependent PRs (#23283 , #23296 )
chore: [Booking Refactor - Preparation - 0]Move modules required by RegularBookingService to moduleLoader format #23740
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

hariombalhara · 2025-09-24T07:52:15Z

packages/features/bookings/lib/service/RegularBookingService.ts

-    if (error instanceof Error) {
-      throw new HttpError({ statusCode: 410, message: error.message });
-    }
-
-    // For unexpected errors, provide a generic message
-    throw new HttpError({ statusCode: 500, message: "Failed to process booking link" });


Intentionally removed these errors because Booking is actually successful and this is a Post Booking thing, which we should track for errors but booker shouldn't see any booking failure due to it.

hariombalhara · 2025-09-24T07:54:55Z

packages/features/hashedLink/lib/service/HashedLinkService.ts

+  private readonly hashedLinkRepository: HashedLinkRepository;
+  private readonly membershipService: MembershipService;
+
+  constructor(deps: HashedLinkServiceDeps) {


Moved to deps because we have a convention to use deps when there are more than one argument to constructor. This is required by bindModuleToClassOnToken implementation.

volnei

I see we're introducing a new kind of DI which is good but thinking forward I prefer to not go this way right now to maturate a better structure (and place) for DI since lib folder I don't think is the right place.

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts

packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts

hariombalhara · 2025-09-24T16:53:18Z

DI wise I am following the existing conventions, nothing new that I can see.

But yeah if you are talking about moving DI containers and modules to packages/features that we agreed on today, then yes that needs to be done.

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts

- Refactor updatePrivateLinkUsage to only accept hashedLink parameter instead of full payload - Remove shouldProcess function and inline isDryRun check for better clarity - Addresses feedback from PR #24025 Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

github-actions · 2025-10-23T05:01:00Z

E2E results are ready!

Workflow #84598.1 latest results

- Add HashedLinkService to platform-libraries/private-links.ts - Update API V2 to import from platform library instead of direct path - Fixes MODULE_NOT_FOUND error in API V2 build Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts

alishaz-polymath

LGTM 👏

ThyMinimalDev · 2025-10-23T10:37:24Z

@volnei PR looks good to me

…te service `BookingEventHandlerService` starting with HashedLink usage handling (calcom#24025) * chore: Move post booking stuff to separate service * refactor: improve ISP compliance in BookingEventHandlerService - Refactor updatePrivateLinkUsage to only accept hashedLink parameter instead of full payload - Remove shouldProcess function and inline isDryRun check for better clarity - Addresses feedback from PR calcom#24025 Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * define only what is used * Define hashed-link-service as well in api-v2 * fix: export HashedLinkService through platform-libraries - Add HashedLinkService to platform-libraries/private-links.ts - Update API V2 to import from platform library instead of direct path - Fixes MODULE_NOT_FOUND error in API V2 build Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>

pull-request-size bot added the size/XL label Sep 24, 2025

keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Sep 24, 2025

hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from de2c60a to 34dfdce Compare September 24, 2025 07:49

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch from 6e09e8f to 62963b2 Compare September 24, 2025 07:49

hariombalhara changed the title ~~chore: Move post booking stuff to separate service~~ chore: Move post booking things to separate service BookingEventHandler Sep 24, 2025

hariombalhara commented Sep 24, 2025

View reviewed changes

vercel bot had a problem deploying to Preview – dev September 24, 2025 08:09 Failure

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch 2 times, most recently from 148bab2 to 4cfb182 Compare September 24, 2025 08:21

hariombalhara changed the title ~~chore: Move post booking things to separate service BookingEventHandler~~ chore: Move post booking things to separate service BookingEventHandlerService Sep 24, 2025

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch from 4cfb182 to a01b098 Compare September 24, 2025 08:25

vercel bot had a problem deploying to Preview – dev September 24, 2025 08:43 Failure

hariombalhara changed the base branch from hariom/pri-305-bookingcreateservice-rename-handlers-to-services to graphite-base/24025 September 24, 2025 10:33

hariombalhara force-pushed the graphite-base/24025 branch from 34dfdce to 748408d Compare September 24, 2025 11:45

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch from a01b098 to 1326af2 Compare September 24, 2025 11:45

hariombalhara changed the base branch from graphite-base/24025 to hariom/pri-305-bookingcreateservice-rename-handlers-to-services September 24, 2025 11:45

vercel bot deployed to Preview – dev September 24, 2025 12:45 View deployment

volnei previously requested changes Sep 24, 2025

View reviewed changes

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts Show resolved Hide resolved

packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts Outdated Show resolved Hide resolved

hariombalhara force-pushed the hariom/pri-305-bookingcreateservice-rename-handlers-to-services branch from 748408d to 3cbf712 Compare September 26, 2025 08:49

vercel bot deployed to Preview – dev October 22, 2025 11:50 View deployment

ThyMinimalDev reviewed Oct 22, 2025

View reviewed changes

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts Show resolved Hide resolved

ThyMinimalDev reviewed Oct 22, 2025

View reviewed changes

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts Show resolved Hide resolved

ThyMinimalDev reviewed Oct 22, 2025

View reviewed changes

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts Show resolved Hide resolved

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch from c3f6beb to ceb8311 Compare October 22, 2025 13:49

define only what is used

46be34f

hariombalhara force-pushed the hariom-pri-305-post-booking-handling branch from 8696041 to 46be34f Compare October 22, 2025 13:55

hariombalhara requested a review from ThyMinimalDev October 22, 2025 14:01

vercel bot had a problem deploying to Preview – dev October 22, 2025 15:59 Failure

Define hashed-link-service as well in api-v2

289dc20

hariombalhara requested a review from a team as a code owner October 23, 2025 04:20

vercel bot had a problem deploying to Preview – dev October 23, 2025 05:06 Failure

devin-ai-integration bot requested a review from a team October 23, 2025 06:17

vercel bot deployed to Preview – dev October 23, 2025 06:33 View deployment

Merge branch 'main' into hariom-pri-305-post-booking-handling

730175e

alishaz-polymath reviewed Oct 23, 2025

View reviewed changes

packages/features/bookings/lib/onBookingEvents/BookingEventHandlerService.ts Show resolved Hide resolved

alishaz-polymath approved these changes Oct 23, 2025

View reviewed changes

vercel bot had a problem deploying to Preview – dev October 23, 2025 09:29 Failure

Merge branch 'main' into hariom-pri-305-post-booking-handling

dc955c7

vercel bot deployed to Preview – dev October 23, 2025 11:10 View deployment

volnei approved these changes Oct 23, 2025

View reviewed changes

hariombalhara enabled auto-merge (squash) October 23, 2025 12:04

ThyMinimalDev approved these changes Oct 23, 2025

View reviewed changes

hariombalhara merged commit 82951cd into main Oct 23, 2025
39 checks passed

hariombalhara deleted the hariom-pri-305-post-booking-handling branch October 23, 2025 12:05

Comments

Conversation

hariombalhara commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Environment Setup

Test Scenarios

Expected Behavior

Checklist

Uh oh!

linear bot commented Sep 24, 2025

Uh oh!

vercel bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

hariombalhara commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

hariombalhara Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

volnei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hariombalhara commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

Uh oh!

alishaz-polymath left a comment

Choose a reason for hiding this comment

Uh oh!

ThyMinimalDev commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hariombalhara commented Sep 24, 2025 •

edited

Loading

vercel bot commented Sep 24, 2025 •

edited

Loading

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

hariombalhara commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading