Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx">
<violation number="1" location="packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx:328">
`t("trace_reference_id")` uses a translation key that does not exist in the locale files, so users will see the raw key text instead of a localized label. Please add the corresponding translation entry before referencing it.</violation>
</file>
<file name="packages/lib/server/getServerErrorFromUnknown.ts">
<violation number="1" location="packages/lib/server/getServerErrorFromUnknown.ts:129">
This branch now returns a plain Error instead of an HttpError, so callers lose statusCode/message fields and will fail when a string cause is passed.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
Show resolved
Hide resolved
|
We aren't passing tracedError and thus any uncaught error(e.g. I just did a throw new Error() in RegularBookingService) isn't sending the traceId back to client. Also, if we make that change, we won't need to ensure to send traceId in HttpError data like this https://github.com/calcom/cal.com/blob/feat/dist-tracing-3/packages/features/bookings/lib/service/RegularBookingService.ts#L1852 as it would be automatically handled. |
hariombalhara
left a comment
There was a problem hiding this comment.
Left a few small suggestions and a possible bug in functionality
Done and removed traceId from HttpError |

What does this PR do?
This PR is on top of #24861
This PR displays the trace reference id on the frontend
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Adds end-to-end tracing for errors and shows a trace reference in the booking UI. Improves server error normalization across TRPC, Zod, Prisma, and Stripe, with tests.
Written for commit c176be2. Summary will update automatically on new commits.