Skip to content

Comments

feat: dist tracing 4#25574

Merged
alishaz-polymath merged 21 commits intomainfrom
feat/dist-tracing-4
Dec 15, 2025
Merged

feat: dist tracing 4#25574
alishaz-polymath merged 21 commits intomainfrom
feat/dist-tracing-4

Conversation

@Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Dec 3, 2025

What does this PR do?

Follow up to #25092

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?


Summary by cubic

Adds distributed tracing across booking confirmation, webhook dispatch, mandatory reminders, seat handling, and payment webhook flows (Stripe, PayPal, HitPay, BTCPayServer, Alby) to improve observability and structured error logging. Trace context is created at payment webhooks and confirm handler, propagated end-to-end, and spans are added for handle_confirmation, webhook_trigger, and schedule_mandatory_reminder.

  • New Features
    • Propagate TraceContext through RegularBookingService, TRPC confirm handler, seats, payments, handleConfirmation, handleWebhookTrigger, and reminder scheduler.
    • Initialize trace in Stripe, PayPal, HitPay, BTCPayServer, and Alby webhooks; update trace with booking/payment metadata during payment handlers.
    • Replace direct logger calls with tracingLogger to capture errors within span context.

Written for commit 2e66cb2. Summary will update automatically on new commits.

Base automatically changed from feat/dist-tracing-3 to main December 4, 2025 05:51
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 4, 2025
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 8, 2025
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cal-companion Ready Ready Preview Comment Dec 10, 2025 8:35am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Dec 10, 2025 8:35am
cal-eu Ignored Ignored Dec 10, 2025 8:35am

Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions

hariombalhara
hariombalhara previously approved these changes Dec 8, 2025
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

hariombalhara
hariombalhara previously approved these changes Dec 9, 2025
@alishaz-polymath
Copy link
Member

@volnei A quick bless from the foundation please? 🙏

@alishaz-polymath alishaz-polymath enabled auto-merge (squash) December 15, 2025 05:19
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good to me but I'd go with a more homogeneous traces

payment.webhook.stripe
payment.webhook.other-provider
booking.confirm

specially avoiding names like handler.
The idea is to create a hierarchy of tracings and avoid things like

stripe.handler
alby.payment.confirm
test.confirm.handler

Approved, but I strongly recommend a tracing name revision and a documentation on how tracing names are structured.

@alishaz-polymath alishaz-polymath merged commit 4e1d05a into main Dec 15, 2025
63 of 65 checks passed
@alishaz-polymath alishaz-polymath deleted the feat/dist-tracing-4 branch December 15, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants