Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
packages/features/ee/workflows/lib/reminders/scheduleMandatoryReminder.ts
Outdated
Show resolved
Hide resolved
hariombalhara
previously approved these changes
Dec 9, 2025
hariombalhara
approved these changes
Dec 10, 2025
alishaz-polymath
approved these changes
Dec 15, 2025
Member
|
@volnei A quick bless from the foundation please? 🙏 |
volnei
approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
In general it looks good to me but I'd go with a more homogeneous traces
payment.webhook.stripe
payment.webhook.other-provider
booking.confirm
specially avoiding names like handler.
The idea is to create a hierarchy of tracings and avoid things like
stripe.handler
alby.payment.confirm
test.confirm.handler
Approved, but I strongly recommend a tracing name revision and a documentation on how tracing names are structured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #25092
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Adds distributed tracing across booking confirmation, webhook dispatch, mandatory reminders, seat handling, and payment webhook flows (Stripe, PayPal, HitPay, BTCPayServer, Alby) to improve observability and structured error logging. Trace context is created at payment webhooks and confirm handler, propagated end-to-end, and spans are added for handle_confirmation, webhook_trigger, and schedule_mandatory_reminder.
Written for commit 2e66cb2. Summary will update automatically on new commits.