Skip to content

fix: resolve useLiteralKeys biome lint issues#26851

Merged
volnei merged 2 commits intomainfrom
devin/fix-use-literal-keys-1768418318
Jan 14, 2026
Merged

fix: resolve useLiteralKeys biome lint issues#26851
volnei merged 2 commits intomainfrom
devin/fix-use-literal-keys-1768418318

Conversation

@volnei
Copy link
Contributor

@volnei volnei commented Jan 14, 2026

What does this PR do?

Fixes all 33 lint/complexity/useLiteralKeys biome lint issues across the codebase. This rule prefers dot notation (obj.key) over bracket notation (obj["key"]) for object property access when the key is a valid identifier.

Changes:

  • Converted bracket notation to dot notation where possible (e.g., dataset["buttonText"]dataset.buttonText)
  • Added // biome-ignore comments where bracket notation is required (hyphenated keys like "google-meet" or dynamic properties from external libraries)

Files modified: 10 files across embed-core, lib, and trpc packages

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - lint fixes only
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run yarn turbo run lint -- --max-diagnostics=10000 and verify no useLiteralKeys errors remain
  2. Run yarn type-check:ci to verify no type errors were introduced
  3. The changes are purely syntactic and don't affect runtime behavior

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify enum access changes are correct (BookingStatus.CANCELLED vs BookingStatus["CANCELLED"])
  • Verify biome-ignore comments have appropriate explanations
  • Confirm no functional changes were introduced

Link to Devin run: https://app.devin.ai/sessions/674bbf5e35ff4394a0af3bbff07a2033
Requested by: Volnei Munhoz (@volnei)

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@volnei volnei marked this pull request as ready for review January 14, 2026 19:32
@volnei volnei requested a review from a team as a code owner January 14, 2026 19:32
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 14, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

@volnei volnei enabled auto-merge (squash) January 14, 2026 19:59
@volnei volnei merged commit 5339569 into main Jan 14, 2026
45 checks passed
@volnei volnei deleted the devin/fix-use-literal-keys-1768418318 branch January 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments