Skip to content

[CLEAN] Synthetic Benchmark PR #26851 - fix: resolve useLiteralKeys biome lint issues#677

Closed
tomerqodo wants to merge 1 commit intobase_pr_26851_20260121_1803from
clean_pr_26851_20260121_1803
Closed

[CLEAN] Synthetic Benchmark PR #26851 - fix: resolve useLiteralKeys biome lint issues#677
tomerqodo wants to merge 1 commit intobase_pr_26851_20260121_1803from
clean_pr_26851_20260121_1803

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#26851

Type: Clean (correct implementation)

Original PR Title: fix: resolve useLiteralKeys biome lint issues
Original PR Description: ## What does this PR do?

Fixes all 33 lint/complexity/useLiteralKeys biome lint issues across the codebase. This rule prefers dot notation (obj.key) over bracket notation (obj["key"]) for object property access when the key is a valid identifier.

Changes:

  • Converted bracket notation to dot notation where possible (e.g., dataset["buttonText"]dataset.buttonText)
  • Added // biome-ignore comments where bracket notation is required (hyphenated keys like "google-meet" or dynamic properties from external libraries)

Files modified: 10 files across embed-core, lib, and trpc packages

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - lint fixes only
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run yarn turbo run lint -- --max-diagnostics=10000 and verify no useLiteralKeys errors remain
  2. Run yarn type-check:ci to verify no type errors were introduced
  3. The changes are purely syntactic and don't affect runtime behavior

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify enum access changes are correct (BookingStatus.CANCELLED vs BookingStatus["CANCELLED"])
  • Verify biome-ignore comments have appropriate explanations
  • Confirm no functional changes were introduced

Link to Devin run: https://app.devin.ai/sessions/674bbf5e35ff4394a0af3bbff07a2033
Requested by: Volnei Munhoz (@volnei)
Original PR URL: calcom#26851

Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #26851 - fix: resolve useLiteralKeys biome lint issues". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Feb 3, 2026
@github-actions
Copy link

This PR has been closed due to inactivity. Please feel free to reopen it if you'd like to continue the work.

@github-actions github-actions bot closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments