[CLEAN] Synthetic Benchmark PR #26851 - fix: resolve useLiteralKeys biome lint issues#677
Closed
tomerqodo wants to merge 1 commit intobase_pr_26851_20260121_1803from
Closed
[CLEAN] Synthetic Benchmark PR #26851 - fix: resolve useLiteralKeys biome lint issues#677tomerqodo wants to merge 1 commit intobase_pr_26851_20260121_1803from
tomerqodo wants to merge 1 commit intobase_pr_26851_20260121_1803from
Conversation
Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
This PR has been closed due to inactivity. Please feel free to reopen it if you'd like to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR calcom#26851
Type: Clean (correct implementation)
Original PR Title: fix: resolve useLiteralKeys biome lint issues
Original PR Description: ## What does this PR do?
Fixes all 33
lint/complexity/useLiteralKeysbiome lint issues across the codebase. This rule prefers dot notation (obj.key) over bracket notation (obj["key"]) for object property access when the key is a valid identifier.Changes:
dataset["buttonText"]→dataset.buttonText)// biome-ignorecomments where bracket notation is required (hyphenated keys like"google-meet"or dynamic properties from external libraries)Files modified: 10 files across embed-core, lib, and trpc packages
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn turbo run lint -- --max-diagnostics=10000and verify nouseLiteralKeyserrors remainyarn type-check:cito verify no type errors were introducedChecklist
Human Review Checklist
BookingStatus.CANCELLEDvsBookingStatus["CANCELLED"])Link to Devin run: https://app.devin.ai/sessions/674bbf5e35ff4394a0af3bbff07a2033
Requested by: Volnei Munhoz (@volnei)
Original PR URL: calcom#26851