feat: clear all filters when deselecting a segment#26920
Merged
eunjae-lee merged 2 commits intomainfrom Jan 16, 2026
Merged
Conversation
When a segment is selected and clicked again to deselect, now calls clearAll() instead of just setSegmentId(null) to also clear all active filters. Added e2e tests to verify the behavior for both system and user segments. Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Moved the 'Deselecting a segment clears all active filters' test from system-segments.e2e.ts to filter-segment.e2e.ts since the behavior applies to all segments, not just system segments. Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
eunjae-lee
deleted the
devin/clear-filters-on-segment-deselect-1768556137
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a filter segment is selected and the user clicks it again to deselect, this PR now clears all active filters in addition to deselecting the segment.
Previously, deselecting a segment only called
setSegmentId(null), which removed the segment selection but left the filters in place. Now it callsclearAll()which clears both the segment selection and all active filters.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
activeFilters)activeFilters)An e2e test has been added to
filter-segment.e2e.ts:Deselecting a segment clears all active filtersChecklist
Human Review Checklist
clearAll()instead ofsetSegmentId(null)is the intended behavior (clears both segment selection and all active filters)