Skip to content

[CORRUPTED] Synthetic Benchmark PR #26920 - feat: clear all filters when deselecting a segment#674

Open
tomerqodo wants to merge 3 commits intobase_pr_26920_20260121_2533from
corrupted_pr_26920_20260121_2533
Open

[CORRUPTED] Synthetic Benchmark PR #26920 - feat: clear all filters when deselecting a segment#674
tomerqodo wants to merge 3 commits intobase_pr_26920_20260121_2533from
corrupted_pr_26920_20260121_2533

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#26920

Type: Corrupted (contains bugs)

Original PR Title: feat: clear all filters when deselecting a segment
Original PR Description: ## What does this PR do?

When a filter segment is selected and the user clicks it again to deselect, this PR now clears all active filters in addition to deselecting the segment.

Previously, deselecting a segment only called setSegmentId(null), which removed the segment selection but left the filters in place. Now it calls clearAll() which clears both the segment selection and all active filters.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Go to a page with DataTable and filter segments (e.g., Bookings page or Organization Members page)
  2. Select a filter segment (e.g., "My Bookings" system segment or a user-created segment)
  3. Verify filters are applied (URL contains activeFilters)
  4. Click the same segment again to deselect it
  5. Verify the segment is deselected AND all filters are cleared (URL should no longer contain activeFilters)

An e2e test has been added to filter-segment.e2e.ts:

  • Deselecting a segment clears all active filters

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify that calling clearAll() instead of setSegmentId(null) is the intended behavior (clears both segment selection and all active filters)
  • Consider if there are use cases where users might want to keep filters when deselecting a segment

Link to Devin run: https://app.devin.ai/sessions/44f22b80d9c442bdb334d04dac2b476d
Requested by: @eunjae-lee
Original PR URL: calcom#26920

devin-ai-integration bot and others added 3 commits January 21, 2026 15:38
When a segment is selected and clicked again to deselect, now calls
clearAll() instead of just setSegmentId(null) to also clear all active
filters.

Added e2e tests to verify the behavior for both system and user segments.

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Moved the 'Deselecting a segment clears all active filters' test from
system-segments.e2e.ts to filter-segment.e2e.ts since the behavior
applies to all segments, not just system segments.

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CORRUPTED] Synthetic Benchmark PR #26920 - feat: clear all filters when deselecting a segment". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments