fix: remove sticky positioning from page headers in pages on scroll#27242
fix: remove sticky positioning from page headers in pages on scroll#27242dhairyashiil merged 4 commits intocalcom:mainfrom
Conversation
dhairyashiil
left a comment
There was a problem hiding this comment.
messing with other pages as well, check event types/advanced page
Screen.Recording.2026-01-26.at.7.05.08.PM.mov
Thanks for spotting ! |
welcome : ) |
|
@eeshm i have pushed one commit, this works as expected on workflows pages and not creating regression on other pages, could you please check if what i pushed is the optimal solution and if yes could you apply the same on other pages as well? if this is not optimal, please feel free to change the implementation. please check all the pages after your fix, and attach all the videos |
|
hi, thanks for catching it and sorry my approach was too broad. Your approach mostly look fine, i'll verify it locally and apply changes on other pages. |
Applied disableSticky={true} to remaining affected pages:
- Routing Forms page
- Organization Members view
- Platform Members view
|
hi @dhairyashiil, checked locally and your fix was optimal and is not creating regression on other pages. additional changes applied to:
videos:
|
What does this PR do?
Headers and subheaders were fixed to the top when scrolling on some pages like workflows, routing forms, and org members pages.
Only some pages showed this behaviour because other pages (event types, bookings) use
ShellMainAppDirwhich never had sticky position.Visual Demo (For contributors especially)
cursorful-video-1769430261186.mp4
cursorful-video-1769430334656.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?