Skip to content

fix: remove sticky positioning from page headers in pages on scroll #27242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhairyashiil merged 4 commits into from
Jan 26, 2026
Merged

fix: remove sticky positioning from page headers in pages on scroll #27242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e33643c
fix: remove sticky positioning from page headers in pages using Shell…
eeshm Jan 26, 2026
a8554ac
correct fix (mostly)
dhairyashiil Jan 26, 2026
01097f1
Merge branch 'calcom:main' into fix/remove-sticky-header-positioning
eeshm Jan 26, 2026
682ac95
fix: disable sticky headers on routing forms and members pages
eeshm Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/web/app/(use-page-wrapper)/apps/routing-forms/forms/[[...pages]]/Forms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export default function RoutingForms({ appUrl }: { appUrl: string }) {
return (
<LicenseRequired>
<ShellMain
disableSticky={true}
heading={t("routing")}
CTA={
hasPaidPlan && forms?.length ? (
Expand Down
1 change: 1 addition & 0 deletions ...web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/[id]/members/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
return (
<Shell
withoutMain={false}
disableSticky={true}
heading={t("organization_members")}
subtitle={t("organization_description")}
headerClassName="hidden md:block"
Expand Down
1 change: 1 addition & 0 deletions apps/web/app/(use-page-wrapper)/settings/platform/members/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
/>
</div>
}
disableSticky={true}
title={t("platform_members")}
subtitle={t("platform_members_description")}
withoutMain={false}
Expand Down
1 change: 1 addition & 0 deletions apps/web/modules/ee/workflows/views/WorkflowsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ function WorkflowsPage({ filteredList }: PageProps) {
<Shell withoutMain>
<LicenseRequired>
<ShellMain
disableSticky={true}
heading={t("workflows")}
subtitle={t("workflows_to_automate_notifications")}
title={t("workflows")}
Expand Down
6 changes: 4 additions & 2 deletions apps/web/modules/shell/Shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export type LayoutProps = {
afterHeading?: ReactNode;
smallHeading?: boolean;
isPlatformUser?: boolean;
disableSticky?: boolean;
};

const KBarWrapper = ({ children, withKBar = false }: { withKBar: boolean; children: React.ReactNode }) =>
Expand Down Expand Up @@ -132,8 +133,9 @@ export function ShellMain(props: LayoutProps) {
{(props.heading || !!props.backPath) && (
<div
className={classNames(
"bg-default sticky top-0 z-10 mb-0 flex items-center md:mb-6 md:mt-0",
props.smallHeading ? "lg:mb-7" : "lg:mb-8"
"bg-default mb-0 flex items-center md:mb-6 md:mt-0",
props.smallHeading ? "lg:mb-7" : "lg:mb-8",
!props.disableSticky && "sticky top-0 z-10"
)}>
{!!props.backPath && (
<Button
Expand Down
Loading