Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: positioning of arrows #4478

Merged
merged 4 commits into from
Sep 20, 2022
Merged

fix: positioning of arrows #4478

merged 4 commits into from
Sep 20, 2022

Conversation

Udit-takkar
Copy link
Contributor

Fixes: #4464

Screenshot 2022-09-15 at 2 39 19 AM

@vercel
Copy link

vercel bot commented Sep 14, 2022

@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@emrysal
Copy link
Contributor

emrysal commented Sep 14, 2022

It works but the use of -mt-10 does not sit right with me, do you reckon it would be possible to always align to the HR like <flex items-center><buttons><hr /></endflex> ? Thinking out loud here

@Udit-takkar
Copy link
Contributor Author

@emrysal no just tried this. the in FormCard is under route 2 heading in image but we want to center it according to second divider which is in children.

Screenshot 2022-09-20 at 12 02 52 AM

@Udit-takkar
Copy link
Contributor Author

Udit-takkar commented Sep 19, 2022 •
edited
Loading

Screenshot 2022-09-20 at 12 10 01 AM

this is how it would look like

If i use

<div items-center>
    <buttonsDiv>
    {children}
<div>

@hariombalhara
Copy link
Member

Thanks @Udit-takkar

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 20, 2022
@kodiakhq kodiakhq bot merged commit ae46d61 into calcom:main Sep 20, 2022
emrysal added a commit that referenced this pull request Sep 20, 2022
@PeerRich @alannnc
@hariombalhara @leog @kodiakhq @github-actions @crowdin-bot @afzalsayed96 @joeauyeung @gitstart @niteshsingh1357 @matheusmuniz03 @seunexplicit @gracebir @Thiagomn1 @emrysal @Udit-takkar @G3root
prod (#4633)
4ea0be8 
* fix isSelectedProp for settings/calendars switches (#4589)

* Hotfix/ Embed Tabs (#4593)

* Fixing installed app navigation (#4595)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Embed width increase to allow preview to work in desktop mode (#4547)

* fixed settings teams rewrite

* fixed 404 signup page (#4603)

* New Crowdin translations by Github Action (#4599)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* Fix event type navigation (#4565)

* Fix event type navigation

* Fix dropdown focus styling

* Fix border radius

* Remove stray classname

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>

* typo in /more (#4610)

Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com>
Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: Grace Nshokano <grace.devolop@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>

* Return 401 on null keys (#4616)

* Fix wrong team link (#4620)

* Fixes #4380 (#4615)

* fix: positioning of arrows (#4478)

Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* Fixes #4606 - Add guests cannot be removed (#4609)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat: animate event list while reordering (#4611)

* fix: prevent waiting while invalidating

* feat: add auto animate

* static postion is added to animation container because auto animate adding
a inline style of position relative, which breaks arrow buttons
position.

* fix: wait until query get cancelled

* fix: set querydata correctly

Co-authored-by: Alex van Andel <me@alexvanandel.com>

Co-authored-by: alannnc <alannnc@gmail.com>
Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: Leo Giovanetti <hello@leog.me>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Afzal Sayed <14029371+afzalsayed96@users.noreply.github.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com>
Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com>
Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: Grace Nshokano <grace.devolop@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com>
Co-authored-by: Alex van Andel <me@alexvanandel.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees
No one assigned
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/routing-forms - reordering alignment is not centered
4 participants
@Udit-takkar @emrysal @hariombalhara @PeerRich