-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes /availability/single-view - start date doesn't reflects settings #4615
Fixes /availability/single-view - start date doesn't reflects settings #4615
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
weekStart={ | ||
["Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"].indexOf( | ||
me.data?.weekStart | ||
) as 0 | 1 | 2 | 3 | 4 | 5 | 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) as 0 | 1 | 2 | 3 | 4 | 5 | 6 | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: weekStart prop is a number
type and thus it doesn't need type assertion
Also, the result can be -1 as well so assertion isn't correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fair, it's a copy paste from similar places (I'm debating with myself whether to move weekStart logic into the schedule component itself).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can have UserSchedule Higher Order Component that can have user specific settings preconfigured.
* fix isSelectedProp for settings/calendars switches (#4589) * Hotfix/ Embed Tabs (#4593) * Fixing installed app navigation (#4595) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Embed width increase to allow preview to work in desktop mode (#4547) * fixed settings teams rewrite * fixed 404 signup page (#4603) * New Crowdin translations by Github Action (#4599) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Fix event type navigation (#4565) * Fix event type navigation * Fix dropdown focus styling * Fix border radius * Remove stray classname Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> * typo in /more (#4610) Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * Return 401 on null keys (#4616) * Fix wrong team link (#4620) * Fixes #4380 (#4615) * fix: positioning of arrows (#4478) Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Fixes #4606 - Add guests cannot be removed (#4609) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat: animate event list while reordering (#4611) * fix: prevent waiting while invalidating * feat: add auto animate * static postion is added to animation container because auto animate adding a inline style of position relative, which breaks arrow buttons position. * fix: wait until query get cancelled * fix: set querydata correctly Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Afzal Sayed <14029371+afzalsayed96@users.noreply.github.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com>
Fixes #4380