chore: add a test for public API #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
chore/public-api-test
branch
from
35b3b1e to
acc3be8
Compare
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 97.5% 97.73% +0.23%
==========================================
Files 19 19
Lines 401 398 -3
Branches 74 74
==========================================
- Hits 391 389 -2
+ Misses 10 9 -1
Continue to review full report at Codecov.
|
satya164
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were missing a test for our public API, so I added one
Test plan
CI should be red, waiting for #129 to land