fix: correct type inference for props when initialProps is used #1421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1420
Because we were using conditionals in RenderHookOptions and the way Typescript works with conditionals, Props type was inferred too strictly. For instance when doing:
Props type would be infered as 5 and not number | undefined which would be the expected type.
This PR fixes this issue by removing the use of the conditional. This doesn't change much the behavior and it aligns with the types from testing library react hooks and react testing library
Test plan
I added a test case to check that the type is inferred correctly