Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type inference for props when initialProps is used #1421

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/__tests__/renderHook.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,37 @@ test('allows wrapper components', async () => {

expect(result.current).toEqual('provided');
});

const useMyHook = (param: number | undefined) => {
return param;
};

test('props type is infered correctly when initial props is defined', () => {
const { result, rerender } = renderHook(
(num: number | undefined) => useMyHook(num),
{
initialProps: 5,
}
);

expect(result.current).toBe(5);

rerender(6);

expect(result.current).toBe(6);
});

test('props type is infered correctly when initial props is explicitly undefined', () => {
mdjastrzebski marked this conversation as resolved.
Show resolved Hide resolved
const { result, rerender } = renderHook(
(num: number | undefined) => useMyHook(num),
{
initialProps: undefined,
}
);

expect(result.current).toBeUndefined();

rerender(6);

expect(result.current).toBe(6);
});
12 changes: 4 additions & 8 deletions src/renderHook.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,12 @@ export type RenderHookResult<Result, Props> = {
unmount: () => void;
mdjastrzebski marked this conversation as resolved.
Show resolved Hide resolved
};

export type RenderHookOptions<Props> = Props extends
| object
| string
| number
| boolean
? {
initialProps: Props;
export type RenderHookOptions<Props> =
| {
initialProps?: Props;
wrapper?: ComponentType<any>;
}
: { wrapper?: ComponentType<any>; initialProps?: never } | undefined;
| undefined;
mdjastrzebski marked this conversation as resolved.
Show resolved Hide resolved

export function renderHook<Result, Props>(
renderCallback: (props: Props) => Result,
Expand Down