fix: don't cache failed script #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 664377e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hosseinmd
force-pushed
the
cacheFailedScript
branch
from
7a9c81a
to
3e0fb49
Compare
hosseinmd
force-pushed
the
cacheFailedScript
branch
from
3e0fb49
to
0ecf567
Compare
jbroma
reviewed
Oct 28, 2024
There was a problem hiding this comment.
hey @hosseinmd, sorry for the late reply and thanks again for yet another contribution 🎉. I was on sick leave during last week so wasn't able to get to this any sooner.
Overall, the changes in code looks good, I just need some explanation for the tests, take a look 👇
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Show resolved
Hide resolved
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Show resolved
Hide resolved
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Outdated
Show resolved
Hide resolved
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Outdated
Show resolved
Hide resolved
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Outdated
Show resolved
Hide resolved
hosseinmd
force-pushed
the
cacheFailedScript
branch
from
18e15bd
to
664377e
Compare
jbroma
reviewed
Oct 29, 2024
packages/repack/src/modules/ScriptManager/__tests__/ScriptManager.test.ts
Show resolved
Hide resolved
|
Thank you for your contribution @hosseinmd 👏🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#770
The root cause was where cache is saving, script Resolver should not save the cache, it should be saved after script loaded successfully.
Test plan
I added a test for failing scenario which expected to The failed script doesn't save on cache and also if scriptLoader called again, expected in second time fetch property should be true too.