Revert Visitor Interface #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachitnigam
force-pushed
the
visitor-revert
branch
from
393c531 to
04cc560
Compare
|
@sgpthomas will take a look at this before merging. Some of the code, specifically the two pass approach to |
sgpthomas
requested changes
Dec 8, 2020
sgpthomas
approved these changes
Dec 16, 2020
|
I haven't fixed #314 yet. but the analysis handles the other problems correctly now. I think that we should merge this and then improve the live range analysis because other things depend upon this. @rachitnigam |
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293.
analysis::LiveRangeAnalysis.