Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement invoke #300

Merged
merged 20 commits into from
Dec 17, 2020
Merged

Implement invoke #300

merged 20 commits into from
Dec 17, 2020

Conversation

rachitnigam
Copy link
Contributor

@rachitnigam rachitnigam commented Dec 8, 2020

Basic implementation for invoke.

TODO:

  • Implement compilation for invoke
  • Remove the unimplemented!() macro calls.
    • Punt this to the next PR.

@rachitnigam rachitnigam changed the base branch from master to visitor-revert December 8, 2020 23:46
@rachitnigam
Copy link
Contributor Author

Ready to demo this today!

@rachitnigam
Copy link
Contributor Author

I feel that generating the once register is unnecessary. The control logic that calls the generated invoke group immediately shuts off the execution once the done signal is high. Furthermore, the control logic also makes sure that the path from the go signal to the done signal has a register in between.

TLDR: Generation can probably just be

group invoke {
  comp.go = 1'd1;
  comp.arg1 = ...;
  invoke[done] = comp.done;
}

@rachitnigam
Copy link
Contributor Author

This is ready to merge. Waiting on #295.

Base automatically changed from visitor-revert to master December 16, 2020 21:46
@rachitnigam rachitnigam merged commit cbbe2b1 into master Dec 17, 2020
@rachitnigam rachitnigam deleted the invoke branch December 17, 2020 20:09
@rachitnigam rachitnigam mentioned this pull request Dec 17, 2020
3 tasks
@sampsyo
Copy link
Contributor

sampsyo commented Dec 18, 2020

Woohoo! Long live invoke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants