Parser tweaks #443
Merged
Parser tweaks #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me (LGTM)! Squash and merge when ready! |
sgpthomas
pushed a commit
that referenced
this pull request
Mar 22, 2021
* added check to ensure literal values are representable in the given bitwidth * added a few tests * fix edge case * fix my formatting crimes * appease clippy * formatting, again
sgpthomas
added a commit
that referenced
this pull request
Mar 23, 2021
* add test for minimize regs rewriting conditions * changing trait bounds + improved doc comments * add `sharing_component.rs` to abstract common details between minimize-regs and resource-sharing. fixes #442 * documentation + clippy fixes * [fud] Errors in Fud prints out STDOUT * Attempt to serialize workflows (#432) * Give @external semantics for verilog backend (#430) * Give @external semantics for verilog backend @external(1) on a memory makes the backend generate code to initialize memories and dump out their final states. Every other memory is ignored. Fud is stricter about what memories it expects in the inputs and outputs. * fmt * relay memories are external * fmt * line nonsense * more reformat * more test fixing * Tests * Commas are the worst * undo change to pow test Co-authored-by: cgyurgyik <gyurgyikcp@gmail.com> * unify mod and div implements (#433) * remove std_ prefix from math library (#431) * remove std_ prefix from math library * update test * update relay impl * Add prefix and suffix to Relay components. * Add arity only. * Remove re. Co-authored-by: Chris Gyurgyik <37983775+cgyurgyik@users.noreply.github.com> Co-authored-by: cgyurgyik <gyurgyikcp@gmail.com> * Test Language Tutorial examples (#436) * Test Language Tutorial examples * update doc link * add data.json * link to calyx files * [docs] Tutorial for memory by reference. (#441) * Tutorial for memory by reference. * Update english * runt * Use mod output. * Update Summary. * rename. * Fix test. * [obvious] Change table to columns. * [obvious] Small grammatical changes. * [obvious] Fix typo. * Parser tweaks (#443) * added check to ensure literal values are representable in the given bitwidth * added a few tests * fix edge case * fix my formatting crimes * appease clippy * formatting, again * fixed condition register test, removed rename swap Co-authored-by: Rachit Nigam <rachit.nigam12@gmail.com> Co-authored-by: cgyurgyik <gyurgyikcp@gmail.com> Co-authored-by: Chris Gyurgyik <37983775+cgyurgyik@users.noreply.github.com> Co-authored-by: Griffin Berlstein <griffin@berlste.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parser error messages for literals that cannot be represented in the given bitwidth. Closes #438.
Will need to be adjusted later to support zero width literals like
0'null