Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMARA_common.yaml - info object correction to align with API Design Guidelines #257

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jul 22, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

Info object correction to align with API Design Guidelines
Optional contact field removed.
Added: x-camara-commonalities: 0.4.0 indicating Commonalities version.

Which issue(s) this PR fixes:

Fixes #254

Special notes for reviewers:

To be included in RC.2

Changelog input

Info object in CAMARA_common.yaml aligned with API Design Guidelines

Additional documentation

This section can be blank.

docs

Info object correction to align with API Design Guidelines
@rartych rartych marked this pull request as ready for review July 22, 2024 15:10
@rartych rartych requested a review from hdamker July 22, 2024 15:12
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar shilpa-padgaonkar merged commit 9233f83 into camaraproject:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version within CAMARA_common.yaml shouldn't be "wip"
7 participants