-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparing for a Release #36
preparing for a Release #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks
Hi @DT-DawidWroblewski @bigludo7 |
this API used client credentials from the very beginning, as it does not involve user resource. Therefore, we can use client credentials here explicitly. I see no reason to make this update. @bigludo7 what do you think about it? |
Hello @fernandopradocabrillo @DT-DawidWroblewski This is a good sample to discuss ! .... probably should be raise here: camaraproject/IdentityAndConsentManagement#57 Question for Fernando: Do we want for an API like this one go thru openIdConnect as securityScheme type which is a bit cumbersome, and not usual for this kind of API, for the sake of CAMARA global consistency? |
Actually my opinion on forcing OpenId is not that strong on this one. On one side I think that, for this case specifically, leaving the Client Credentials may be just good enough since the auth flow is pretty clear and not that opened to discussion as it may be in Sim swap or Number Verification. |
Would a solution that works with opened and meets local privacy regulation be beneficial? |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
to create a v0.5.0 release
Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
Additional documentation