-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the statusInfo
as parameter to the SessionInfo
#273
feat: add the statusInfo
as parameter to the SessionInfo
#273
Conversation
LGTM - but should be merged only after the patch release 0.10.1 is done (and then the documentation need to be changed accordingly again). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using more anonymous urls and public IPs?
According to upcoming API Version guidelines, see https://wiki.camaraproject.org/display/CAM/API+versioning+throughout+the+release+management+process
@hdamker, yes I will continue on that next Monday. |
…d-statusinfo-to-sessioninfo # Conflicts: # code/API_definitions/qod-api.yaml
@hdamker PR is updated to version 0.11.0-wip and conflicts were resolved. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove "(the statusInfo
parameter is not included in the current version but will be adding to SessionInfo
in an upcoming release)" from line 107
Good catch, reversing the documentation fix for 0.10.1. More precise: the sentence in line 106/107 need to reverse the PR #267, so changing the lines 106/107 back to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds the
statusInfo
as parameter to theSessionInfo
Which issue(s) this PR fixes:
Fixes #267