Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum duration in session info and improve documentation #277

Conversation

emil-cheung
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • bug
  • documentation

What this PR does / why we need it:

  • Improve the documentation of "Extend the duration of an active session".
  • Improve the datatype "SessionInfo" to remove the maximum limit of duration.

Which issue(s) this PR fixes:

Fixes #272

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

linux-foundation-easycla bot commented Apr 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@emil-cheung emil-cheung changed the title Emil cheung fix maximum duration in session info Fix maximum duration in session info and improve documentation Apr 2, 2024
@hdamker hdamker requested a review from akoshunyadi April 4, 2024 14:11
code/API_definitions/qod-api.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some corrections

code/API_definitions/qod-api.yaml Outdated Show resolved Hide resolved
code/API_definitions/qod-api.yaml Outdated Show resolved Hide resolved
code/API_definitions/qod-api.yaml Outdated Show resolved Hide resolved
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
@hdamker
Copy link
Collaborator

hdamker commented Apr 8, 2024

@eric-murray @RandyLevensalor @jlurien @akoshunyadi Could you please do the final review/approval until Wednesday, April 10th? Thanks!

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker hdamker merged commit e891e9a into camaraproject:main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum duration 86400 in SessionInfo cannot support 'Extend Session Duration'
5 participants