Upgrade starlark-rust to current HEAD #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows change from facebook/starlark-rust@9a7b00e which removed it in starlark_bin Basically get_registered_starlark_docs returned only some random symbols built in into the binary itself, namely: list, StackFrame, dict, string Needed to upgrade starlark-rust, will follow-up with changes needed by Rewrite of DocParams in facebook/starlark-rust@723a272
Rewrite happened in facebook/starlark-rust@723a272
This was referenced Dec 3, 2024
cameron-martin
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades stalark-rust to the current HEAD and contains required fixes to bazel-lsp. Previous version was from Sep 3, and there were a lot of changes in the mean time.
This fixes e.g. #62
Changes
remove get_registered_starlark_docs
This follows change from facebook/starlark-rust@9a7b00e which removed it in starlark_bin
Basically get_registered_starlark_docs returned only some random symbols built in into the binary itself, namely: list, StackFrame, dict, string
adapt to starlark-rust rewrite DocParams
Rewrite happened in facebook/starlark-rust@723a272