Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subpullrequests: camicroscope/SlideLoader#68 camicroscope/iipImage#17
.dcm
extensioncaMicroscope/image-decoders
, our new repo, as the base Dockerfile that builds OpenSlide. If needed,FROM camicroscope/image-decoders
can replaced withapt-get install libopenslide0
.Before merging, Tony and Nan don't have access to caMicroscope Docker so @birm could you please publish an image of currnet https://github.com/camicroscope/image-decoders to Docker Hub so that we can change the images to be downloaded from camicroscope rather than currently my repo for easy testing.
caMicroscope.yml for testing my three pullrequests:
What do you think?