Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM #17

Merged
merged 3 commits into from
Aug 2, 2023
Merged

DICOM #17

merged 3 commits into from
Aug 2, 2023

Conversation

CGDogan
Copy link
Contributor

@CGDogan CGDogan commented Jul 28, 2023

Main discussion at: camicroscope/caMicroscope#647

  • Allow DCM
  • Build OpenSlide somewhere else

CGDogan added 2 commits July 26, 2023 19:51
if we build it ourselves, better in a separate dockerfile or a separate bashscript
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't quite understand why we're using this new base image.

@CGDogan
Copy link
Contributor Author

CGDogan commented Aug 1, 2023

Thank you @birm , because we need the new Openslide for both the Slideloader and the iipsrv and it'll also have the BioFormats decoder. It helps us avoid compiling all of these twice.

Thank you for replying to my last email about converting instead of reading from BioFormats. Afterwards I experimented with conversion and concluded that it was both slow and unreliable in terms of the final file size (current /infile/pyramid/outfile.tiff converter works fine as it works with single layers and usually small images; the opposite for what bioformats may be used for). Then I had a meeting with Tony and he approved my proposed path of continuing with tileserving instead of converting, so imagedecoders repo/image will also have the java+bioformats installation. My plan is to have two scripts there to be run by docker, one for openslide, one for java and bioformats, but using a common image allows compiling these just once. Please let me know if you have any suggestions @birm .

@birm birm merged commit a025c04 into camicroscope:develop Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants