Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Github Workflow for Accessibility Testing (Using Axe) #879

Closed
wants to merge 20 commits into from
Closed

Conversation

nwanduka
Copy link
Contributor

Created axe.yml file in the workflows folder that will check for accessibility issues when a push or PR is made

With respect to this discussion, I created this workflow to automatically run accessibility checks using the Axe accessibility tool

Summary

Motivation

Testing

Questions

Create axe.yml file in the workflows folder that will check for accessibility issues when a push or PR is made
Comment on lines 4 to 6
branches: [master]
pull_request:
branches: [master]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include develop too!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@birm birm changed the base branch from master to develop March 29, 2024 21:38
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run build --if-present
- run: npm start & npx wait-on http://localhost:4010
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a start script!

"test": "mocha test --recursive",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears so. To add a start script, I need to know the entry point to the application. From my research, it is typically specified in the main field of the package.json file as "index.js" or "app.js" or "server.js". But I don't see it. I've scoured the entire repo and I can't find anything remotely close to it.

I was hoping you could point me in the right direction, please.

@nwanduka
Copy link
Contributor Author

I created another PR (#957) to address this. I'll be closing this PR once I get feedback on the other one and a go-ahead from our mentor to close this one.

@nwanduka nwanduka closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants