-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Github Workflow for Accessibility Testing (Using Axe) #879
Conversation
Create axe.yml file in the workflows folder that will check for accessibility issues when a push or PR is made
branches: [master] | ||
pull_request: | ||
branches: [master] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include develop too!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
node-version: ${{ matrix.node-version }} | ||
- run: npm ci | ||
- run: npm run build --if-present | ||
- run: npm start & npx wait-on http://localhost:4010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a start script!
Line 6 in dae72cf
"test": "mocha test --recursive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears so. To add a start script, I need to know the entry point to the application. From my research, it is typically specified in the main field of the package.json file as "index.js" or "app.js" or "server.js". But I don't see it. I've scoured the entire repo and I can't find anything remotely close to it.
I was hoping you could point me in the right direction, please.
I created another PR (#957) to address this. I'll be closing this PR once I get feedback on the other one and a go-ahead from our mentor to close this one. |
Created axe.yml file in the workflows folder that will check for accessibility issues when a push or PR is made
With respect to this discussion, I created this workflow to automatically run accessibility checks using the Axe accessibility tool
Summary
Motivation
Testing
Questions