Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created GH workflow for accessibility checks #957

Merged
merged 18 commits into from
Apr 29, 2024
Merged

Created GH workflow for accessibility checks #957

merged 18 commits into from
Apr 29, 2024

Conversation

nwanduka
Copy link
Contributor

Summary

Motivation

Testing

Questions

@birm
Copy link
Member

birm commented Apr 12, 2024

Since caMicroscope is already in raw html/js form, we typically just use a http server to host it (see

- run: http-server -s &
)

hope this helps!

@nwanduka
Copy link
Contributor Author

Since caMicroscope is already in raw html/js form, we typically just use a http server to host it (see

- run: http-server -s &

)
hope this helps!

It does help a lot. Thank you so much for the tip. Now I'm past the start script error. There's a challenge though when it starts to run the axe core CLI. It can't find the server hosting the application. I'll try to debug this on my own but if the issue persists, I'll be sure to reach out again.

@nwanduka
Copy link
Contributor Author

After two (may have been more) weeks and 17 commits, I'm thrilled to announce that I've finally had a breakthrough with this task. The workflow works!!! 🤗

image

@birm for your review. I also want to confirm that I'm using the right port. I had been using localhost/4010 and kept encountering errors. So I used this:

global.origin = 'http://127.0.0.1:8080'

@nwanduka nwanduka marked this pull request as ready for review April 16, 2024 21:41
@nwanduka nwanduka changed the base branch from master to develop April 17, 2024 11:16
@birm birm merged commit 306cf8f into camicroscope:develop Apr 29, 2024
0 of 2 checks passed
@birm
Copy link
Member

birm commented Apr 29, 2024

This is great! We'll have some test failures until we get them resolved, but fantastic work!

@nwanduka
Copy link
Contributor Author

This is great! We'll have some test failures until we get them resolved, but fantastic work!

Thank you @birm 😊. And thanks again for your support!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants