Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: archival of version 0.25, part 4: optimize cleanup #2171

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Jun 5, 2023

Description

Part of #1173. Follows #2167.

Intended to merge into unsupported/0.25; will never make it to main.

In #2165, I forgot to remove the optimize docs, all of which are unused in this version. This rectifies that.

There are a lot of files, and it will crush your browser when you try to view them. A summary of what's included:

rm -rf ./optimize
rm -rf ./optimize_versioned_docs
rm -rf ./optimize_versioned_sidebars

The presence of these files has zero effect on the published website, as they are ignored by the build anyway. But for clarity, and to avoid someone jumping into this branch and wondering what those files are for, I'm removing them from this branch.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz self-assigned this Jun 5, 2023
@pepopowitz pepopowitz requested a review from akeller June 5, 2023 19:11
@pepopowitz pepopowitz added dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Jun 5, 2023
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing lags the GitHub experience like trying to review a PR with 1.2K files changed 🪦

@pepopowitz pepopowitz merged commit 7ebeaed into unsupported/0.25 Jun 6, 2023
@pepopowitz pepopowitz deleted the pepopowitz/1173-archiving/isolate-0.25-part-4-optimize-cleanup branch June 6, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants