Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: archival of version 0.25, part 3: manual steps #2167

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Jun 2, 2023

Description

Part of #1173. Follows #2166.

More steps to isolate a site for version 0.25, including:

  • Update the docusaurus.config.js
  • Update the theme components
  • Update CI workflows
  • Update any broken links
  • Update htaccess rules

Not included in this PR, but coming in follow-ups

  • I forgot to remove all the optimize folders! That will create another large PR, so not including it here.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz self-assigned this Jun 2, 2023
@pepopowitz pepopowitz marked this pull request as draft June 2, 2023 21:08
@pepopowitz pepopowitz added dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Jun 2, 2023
…ecause it will take some effort to get docker running correctly, and I think we just don't care about unsupported versions.
Comment on lines -58 to -61
- name: Check internal links
uses: untitaker/hyperlink@0.1.27
with:
args: build/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially controversial. The sitemap & product link checks are definitely not something we want to run, because this is an isolated site containing only one old version. But the internal links of the app is probably still worth checking, if it's not much work.

Unfortunately it isn't "not much work"! I'd have to alter the steps above that run the webserver to run the app in a /0.25 folder, or else the internal link-checking would fail because of the baseURL of /0.25.

My feeling is that it's fine to remove this link-checking. It's an unsupported version of the docs, and if an internal link gets broken over time, I think we just say forget it.

But if you feel strongly that I should get this internal link-checking working, let me know!!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this workflow entirely, as we won't want to run it against the 0.25 site.

@@ -3,7 +3,7 @@ name: publish-prod
on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"
- "0.25.[0-9]+"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to do this? Trigger a 0.25 production build only when we create a 0.25.X release.

🚨 We'll have to make sure we update main to exclude the archived tags before we publish a 0.25.x release! Otherwise I think main will trigger a new prod publish, and deploy the 0.25 site to docs.camunda.io!!! (I think that's what would happen?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to prevent accidental 0.25 deployment to docs.camunda.io is up, at #2172

@@ -37,7 +37,7 @@ jobs:
with:
switches: -avzr --delete
path: build/
remote_path: ${{ secrets.AWS_PROD_PUBLISH_PATH }}
remote_path: ${{ secrets.AWS_PROD_PUBLISH_PATH_UNSUPPORTED }}/0.25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already added this new key to the project secrets (and to the Keeper record that contains these secrets).

@@ -43,7 +39,7 @@ jobs:
with:
switches: -avzr --delete
path: build/
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH }}
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH_UNSUPPORTED }}/0.25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already added this new key to the project secrets (and to the Keeper record that contains these secrets).

.github/workflows/publish-stage.yaml Show resolved Hide resolved
@@ -185,7 +152,7 @@ module.exports = {
},
{
label: "Release cycle",
to: "docs/reference/release-policy",
to: "https://docs.camunda.io/docs/reference/release-policy",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are footer links. A few of these pages don't exist in the 0.25 site, so I pointed them at production instead.

@@ -11,7 +11,7 @@ There are various channels where you can reach us.

- We welcome your **bug** reports and **feature requests** through our community channels mentioned above.

- For **security-related issues**, review our [Security notices](../docs/reference/notices) for the most up-to-date information on known issues and steps to report a vulnerability so we can solve the problem as quickly as possible. Do not use GitHub for security-related issues.
- For **security-related issues**, review our [Security notices](https://docs.camunda.io/docs/reference/notices) for the most up-to-date information on known issues and steps to report a vulnerability so we can solve the problem as quickly as possible. Do not use GitHub for security-related issues.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No page here in 0.25! It feels better to send them somewhere, since it's security stuff.

@@ -32,7 +32,7 @@ const features = [
{
title: "APIs & Tools",
imageUrl: "img/apisclients.png",
url: "/docs/apis-tools/working-with-apis-tools/",
url: "/docs/components/clients/build-your-own-client/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the homepage features. This URL translates pretty well.

@@ -41,7 +41,7 @@ const features2 = [
{
title: "Self-Managed",
imageUrl: "img/self-managed.png",
url: "/docs/self-managed/about-self-managed/",
url: "/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL has nothing related in 0.25! Instead of removing the entire feature block, because that makes it look funny, I left it in and pointed it at the home page. It's "unsupported" so that's safe????

@@ -164,41 +164,6 @@ function Home() {
</div>
</section>
)}
<div className={clsx("hero hero--secondary", styles.heroBanner)}>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these three buttons have a 0.25 page! (Technically one of them does but it just says "TODO"!)

So I removed this whole green block.

@pepopowitz pepopowitz requested a review from akeller June 5, 2023 15:56
@pepopowitz pepopowitz marked this pull request as ready for review June 5, 2023 15:56
static/.htaccess Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only rules remaining are specific to 0.25, and they've been updated so that the left side does not include 0.25 (because the app itself won't receive the 0.25 part of the URL), and the right side does include 0.25 (because otherwise it will redirect outside of the 0.25 app).

Base automatically changed from pepopowitz/1173-archiving/isolate-0.25-part-2-automated to unsupported/0.25 June 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant