-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: archival of version 0.25, part 3: manual steps #2167
Changes from 22 commits
ea8618a
442d458
30026c6
2f6a4c7
3c4019c
fb1dbb8
a9a5c2f
00423cd
a8b3adf
587045a
d28b398
38ab421
8abd64f
bfb4071
caf1152
5a991ee
9eacbb9
9d35da5
8b1b224
ebc5bfd
a466c4e
3daaf78
9f3cba2
3024f8e
cb854ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing this workflow entirely, as we won't want to run it against the 0.25 site. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ name: publish-prod | |
on: | ||
push: | ||
tags: | ||
- "[0-9]+.[0-9]+.[0-9]+" | ||
- "0.25.[0-9]+" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is the right way to do this? Trigger a 0.25 production build only when we create a 0.25.X release. 🚨 We'll have to make sure we update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PR to prevent accidental 0.25 deployment to docs.camunda.io is up, at #2172 |
||
|
||
permissions: | ||
id-token: write | ||
|
@@ -37,7 +37,7 @@ jobs: | |
with: | ||
switches: -avzr --delete | ||
path: build/ | ||
remote_path: ${{ secrets.AWS_PROD_PUBLISH_PATH }} | ||
remote_path: ${{ secrets.AWS_PROD_PUBLISH_PATH_UNSUPPORTED }}/0.25 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've already added this new key to the project secrets (and to the Keeper record that contains these secrets). |
||
remote_host: ${{ secrets.AWS_PROD_PUBLISH_HOST }} | ||
remote_user: ${{ secrets.AWS_PROD_PUBLISH_USER }} | ||
# vvvvv Intentionally missing the AWS_ prefix vvvvv | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,7 @@ name: publish-stage | |
on: | ||
push: | ||
branches: | ||
- "main" | ||
tags-ignore: | ||
- "*" | ||
- "unsupported/0.25" | ||
pepopowitz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
permissions: | ||
id-token: write | ||
|
@@ -20,10 +18,8 @@ jobs: | |
node-version: 16 | ||
- name: Install Dependencies | ||
run: npm ci | ||
- name: Disable Indexing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indexing is already disabled in the config itself. |
||
run: "sed -i 's/noIndex: false/noIndex: true/g' docusaurus.config.js" | ||
- name: Update URL | ||
run: 'sed -i ''s!url: "https://docs.camunda.io"!url: "https://stage.docs.camunda.io"!g'' docusaurus.config.js' | ||
run: 'sed -i ''s!url: "https://unsupported.docs.camunda.io"!url: "https://stage.unsupported.docs.camunda.io"!g'' docusaurus.config.js' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New URLs |
||
- name: Build | ||
run: npm run build | ||
env: | ||
|
@@ -43,7 +39,7 @@ jobs: | |
with: | ||
switches: -avzr --delete | ||
path: build/ | ||
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH }} | ||
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH_UNSUPPORTED }}/0.25 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've already added this new key to the project secrets (and to the Keeper record that contains these secrets). |
||
remote_host: ${{ secrets.AWS_STAGE_PUBLISH_HOST }} | ||
remote_user: ${{ secrets.AWS_STAGE_PUBLISH_USER }} | ||
# vvvvv Intentionally missing the AWS_ prefix vvvvv | ||
|
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is potentially controversial. The sitemap & product link checks are definitely not something we want to run, because this is an isolated site containing only one old version. But the internal links of the app is probably still worth checking, if it's not much work.
Unfortunately it isn't "not much work"! I'd have to alter the steps above that run the webserver to run the app in a /0.25 folder, or else the internal link-checking would fail because of the baseURL of /0.25.
My feeling is that it's fine to remove this link-checking. It's an unsupported version of the docs, and if an internal link gets broken over time, I think we just say forget it.
But if you feel strongly that I should get this internal link-checking working, let me know!!!