Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): prevent 0.25.x tags from accidentally being deployed to docs.camunda.io #2172

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Jun 5, 2023

Part of #1173.

This PR is BLOCKING the deployment of 0.25 to unsupported.docs.camunda.io/0.25.

Description

Excludes any 0.25.x tags from the publish-prod workflow, so that a 0.25 isolated website isn't accidentally deployed to the main/supported/active docs site (docs.camunda.io).

The GitHub docs describe this approach of combining include & exclude tags, as well as the importance of the order.

Context for this PR is discussed here.

Testing

After this is merged, I'll tag a 0.25.x release, and make sure (1) the 0.25 site gets deployed to unsupported.docs.camunda.io, and (2) no deployment occurs to docs.camunda.io. If this change doesn't work, and the 0.25 site gets deployed to docs.camunda.io, I will immediately trigger another full-sized production publish to correct things.

Because of this risk of potential down-time, I'll save the tagging test for US evening time.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.
  • This change is blocking other infrastructure work, but is not urgent for existing users.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz added dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Jun 5, 2023
@pepopowitz pepopowitz requested a review from akeller June 5, 2023 19:37
@pepopowitz pepopowitz self-assigned this Jun 5, 2023
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you made your own checkbox. 10/10, please do again 😆

Because of this risk of potential down-time, I'll save the tagging test for US evening time.

Fair enough. Be loud about this in #ask-documentation. If things get weird, nudge support too until you can revert/fix.

@pepopowitz pepopowitz mentioned this pull request Jun 6, 2023
@pepopowitz pepopowitz merged commit edcf082 into main Jun 6, 2023
@pepopowitz pepopowitz deleted the pepopowitz/1173-archiving/prevent-0-25-stomping branch June 6, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants