chore: reorder automated archival steps #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before the more readable changes
pepopowitz
added
kind/enhancement
akeller
reviewed
Jun 12, 2023
hacks/isolateVersion/allSteps.sh
Outdated
Comment on lines
33
to
38
| if [[ "$script_index" == 2 || -z "$script_index" ]]; then | ||
| source $script_directory/1-deleteOtherVersions.sh | ||
| fi | ||
|
|
||
| if [[ "$script_index" == 2 || -z "$script_index" ]]; then | ||
| source $script_directory/2-deleteOtherVersions.sh | ||
| if [[ "$script_index" == 1 || -z "$script_index" ]]; then | ||
| source $script_directory/2-reduceVersionManifest.sh |
There was a problem hiding this comment.
Is the index here right? The should be mismatched with the source?
There was a problem hiding this comment.
I definitely screwed something up -- I'll fix!
There was a problem hiding this comment.
Just like I screwed up that second sentence 😆 Thank you for interpreting my gibberish.
There was a problem hiding this comment.
fixed in latest commit!
akeller
previously approved these changes
Jun 13, 2023
akeller
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #1173.
Reorders the automated archival steps, so that it's easier to open a PR with just the massive deletion changes, followed by a PR for the more digestible changes.
When should this change go live?
holdlabel or convert to draft PR)?PR Checklist
/versioned_docsdirectory, or they are not for an already released version./docsdirectory (aka/next/), or they are not for future versions.