Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder automated archival steps #2223

Merged
merged 3 commits into from
Jun 13, 2023
Merged

chore: reorder automated archival steps #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d03a8
chore: reorder automated steps, so that it's easier to PR chonky bois…
pepopowitz Jun 12, 2023
223cfd7
fix: numbers are hard
pepopowitz Jun 13, 2023
70da4ef
Merge branch 'main' into pepopowitz/1173-archiving/reorder-automated-…
pepopowitz Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...s/isolateVersion/2-deleteOtherVersions.sh → ...s/isolateVersion/1-deleteOtherVersions.sh
View file
Open in desktop
File renamed without changes.
0 ...isolateVersion/1-reduceVersionManifest.sh → ...isolateVersion/2-reduceVersionManifest.sh
View file
Open in desktop
File renamed without changes.
10 changes: 5 additions & 5 deletions hacks/isolateVersion/allSteps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ script_index=$1

script_directory=$(cd "$(dirname "$0")" && pwd)

if [[ "$script_index" == 1 || -z "$script_index" ]]; then
source $script_directory/1-reduceVersionManifest.sh
if [[ "$script_index" == 2 || -z "$script_index" ]]; then
source $script_directory/1-deleteOtherVersions.sh
fi

if [[ "$script_index" == 2 || -z "$script_index" ]]; then
source $script_directory/2-deleteOtherVersions.sh
if [[ "$script_index" == 1 || -z "$script_index" ]]; then
source $script_directory/2-reduceVersionManifest.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the index here right? The should be mismatched with the source?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely screwed something up -- I'll fix!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like I screwed up that second sentence 😆 Thank you for interpreting my gibberish.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in latest commit!

fi

if [[ "$script_index" == 3 || -z "$script_index" ]]; then
Expand All @@ -46,7 +46,7 @@ if [[ "$script_index" == 4 || -z "$script_index" ]]; then
source $script_directory/4-fixDockerfile.sh
fi

notify "Automated steps are complete!"
notify "Automated steps are complete! For ease of review, consider PR'ing the deletion commits separate from the rest of the changes."
notify "Manual steps that remain:
5. Update the docusaurus.config.js
6. Update the theme components
Expand Down