[Backport stable/8.3] fix: Set variables from ThrowError command #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the test case for the ThrowError command to verify that given variables are set as local variables of the error catch event. (cherry picked from commit bc858f8)
Avoid nested assertion to produce a better failure message if the verification is not fulfilled. (cherry picked from commit 9298f7a)
Adjust the handling of the ThrowError gRPC command to set the variables from the command to the job record. As a result, the variables are set as local variables of the error catch event. (cherry picked from commit bc7f8d8)
(cherry picked from commit d762234)
7 tasks
|
bors merge |
|
👎 Rejected by too few approved reviews |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1080 to
stable/8.3.relates to #1079